Bug 1070330

Summary: running an invalid patch command results in an exception and exit of the CLI
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Tom Fonteyne <tfonteyn>
Component: PatchingAssignee: Emanuel Muckenhuber <emuckenh>
Status: CLOSED DUPLICATE QA Contact: Jan Martiska <jmartisk>
Severity: medium Docs Contact: Russell Dickenson <rdickens>
Priority: medium    
Version: 6.2.0CC: dandread, jason.greene, jawilson, jdoyle, kconner, msimka, olubyans
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-27 10:46:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tom Fonteyne 2014-02-26 15:45:01 UTC 
Run an invalid patch command like these for example:

patch apply /home/tom/bin/cli/customize-6.2/patches/jboss-eap-6.2.1.zip --preserve
patch apply /home/tom/bin/cli/customize-6.2/patches/jboss-eap-6.2.1.zip --override

results in

java.lang.NullPointerException
        at org.jboss.as.patching.cli.PatchHandler.createPatchOperationBuilder(PatchHandler.java:347)
        at org.jboss.as.patching.cli.PatchHandler.doHandle(PatchHandler.java:246)
        at org.jboss.as.cli.handlers.CommandHandlerWithHelp.handle(CommandHandlerWithHelp.java:86)
        at org.jboss.as.cli.impl.CommandContextImpl.handle(CommandContextImpl.java:600)
        at org.jboss.as.cli.impl.CommandContextImpl.handleSafe(CommandContextImpl.java:616)
        at org.jboss.as.cli.impl.CommandContextImpl.interact(CommandContextImpl.java:1204)
        at org.jboss.as.cli.impl.CliLauncher.main(CliLauncher.java:263)
        at org.jboss.as.cli.CommandLineMain.main(CommandLineMain.java:34)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.jboss.modules.Module.run(Module.java:292)
        at org.jboss.modules.Main.main(Main.java:455)

It would be better if invalid commands caused a message like

   Syntax Error - enter "patch --help" for more info

and not to simply crash the jvm
Comment 1 Emanuel Muckenhuber 2014-02-27 10:46:59 UTC 

*** This bug has been marked as a duplicate of bug 1032041 ***