Bug 1072883

I had a Gimp crash, ABRT said that a bugreport was already opened for this trouble (Bug #922622) but I see that it has been closed as errata.
I clone the old bugreport because we are still experiencing the bug in Fedora 20.

Gimp version: gimp-2.8.10-4.fc20.x86_64


+++ This bug was initially created as a clone of Bug #922622 +++

Description of problem:
Opened GIMP (General Image Manipulation Program) and loaded a png image into it, and it crashed. I have no screenshots. Reading back through the backtrace, it appears to be seg fault, 
though just what triggered it will be up to you people to find out. 

Version-Release number of selected component:
gimp-2.8.2-6.fc18

Additional info:
backtrace_rating: 4
cmdline:        gimp-2.8
crash_function: file_open_profile_apply_rgb
executable:     /usr/bin/gimp-2.8
kernel:         3.7.6-201.fc18.x86_64
uid:            1000

Truncated backtrace:
Thread no. 1 (7 frames)
 #0 file_open_profile_apply_rgb at file-open.c:685
 #1 file_open_handle_color_profile at file-open.c:732
 #2 file_open_image at file-open.c:207
 #3 gimp_imagefile_create_thumbnail at gimpimagefile.c:373
 #4 gimp_imagefile_create_thumbnail_weak at gimpimagefile.c:443
 #5 gimp_thumb_box_auto_thumbnail at gimpthumbbox.c:743
 #10 app_run at app.c:256

Potential duplicate: bug 767136

--- Additional comment from trennor on 2013-03-18 01:50:48 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:50 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:52 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:54 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:55 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:57 EDT ---



--- Additional comment from trennor on 2013-03-18 01:50:59 EDT ---



--- Additional comment from trennor on 2013-03-18 01:51:01 EDT ---



--- Additional comment from trennor on 2013-03-18 01:51:03 EDT ---



--- Additional comment from trennor on 2013-03-18 01:51:05 EDT ---



--- Additional comment from trennor on 2013-03-18 01:51:07 EDT ---



--- Additional comment from Nils Philippsen on 2013-03-18 07:46:00 EDT ---

Would you please attach the image file in question? Thanks!

--- Additional comment from Nils Philippsen on 2013-03-18 07:48:43 EDT ---

BTW, please try to reproduce this with the current stable version of the package which is 2.8.4-1.fc18. Thanks!

--- Additional comment from Nils Philippsen on 2013-03-18 07:57:00 EDT ---

The error happens here when dereferencing error, which is NULL:

--- 8< --- app/file/file-open.c -- file_open_profile_apply_rgb() ---
  if (! plug_in_icc_profile_apply_rgb (image, context, progress, run_mode,
                                       &error))
    {
      if (error->domain == GIMP_PLUG_IN_ERROR &&
          error->code   == GIMP_PLUG_IN_NOT_FOUND)
--- >8 -------------------------------------------------------------

--> plug_in_icc_profile_apply_rgb() returns FALSE, but doesn't set the error object, probably right here at the top of the function:

--- 8< --- app/plug-in/plug-in-icc-profile.c -- plug_in_icc_profile_apply_rgb() ---
  if (gimp_image_base_type (image) == GIMP_GRAY)
    return FALSE;
--- >8 ----------------------------------------------------------------------------

I suspect that the image is grayscale which would trigger this codepath. I'm consulting with upstream whether that's a bug in the caller (to not check for error != NULL) or the callee (to not set error in the case of an error).

--- Additional comment from Nils Philippsen on 2013-03-18 08:47:44 EDT ---

I've committed a supposed fix for this issue, but before I build an updated package, I'd really like to test this with an image exhibiting the problem. Please attach it to this bug, thanks!

commit 096c636b67abd7967da645699948c2bd3f8273fb
Author:     Nils Philippsen <nils>
AuthorDate: Mon Mar 18 13:37:17 2013 +0100
Commit:     Nils Philippsen <nils>
CommitDate: Mon Mar 18 13:37:17 2013 +0100

    app: set error in case of error in ICC profile plug-in
    
    The function plug_in_icc_profile_apply_rgb() didn't set the error object
    when bailing out due to being called on a grayscale image, this could
    lead to crashes in callers which just checked the return value, but not
    whether or not an error had been set.

--- Additional comment from Fedora Update System on 2013-06-04 06:09:59 EDT ---

gimp-2.8.4-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc17

--- Additional comment from Fedora Update System on 2013-06-04 06:10:35 EDT ---

gimp-2.8.4-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc18

--- Additional comment from Fedora Update System on 2013-06-04 06:11:11 EDT ---

gimp-2.8.4-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc19

--- Additional comment from Fedora Update System on 2013-06-04 22:35:44 EDT ---

Package gimp-2.8.4-5.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gimp-2.8.4-5.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10064/gimp-2.8.4-5.fc19
then log in and leave karma (feedback).

--- Additional comment from Fedora Update System on 2013-06-07 23:31:43 EDT ---

gimp-2.8.4-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

--- Additional comment from Fedora Update System on 2013-06-11 22:36:07 EDT ---

gimp-2.8.4-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

--- Additional comment from Fedora Update System on 2013-06-13 22:31:58 EDT ---

gimp-2.8.4-5.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

--- Additional comment from Wayne Hammond on 2014-01-05 11:22:50 EST ---

This bug came up when I clicked on the link in the abrt report for a Gimp failure on my computer.

In the interest of adding useful information, this failure happens quite often on y computer and the cause seems to be trying to open a large image before the preview image loads in the "open file" menu item. Initially there is a folder image when the file is clicked on and if one uses a double click without actually seeing the image thumbnail, Gimp fails to load the file and quits. When the thumbnail appears, Gimp can open the file every time without incident.

Wayne