Bug 922622 - [abrt] gimp-2.8.2-6.fc18: file_open_profile_apply_rgb: Process /usr/bin/gimp-2.8 was killed by signal 11 (SIGSEGV)
Summary: [abrt] gimp-2.8.2-6.fc18: file_open_profile_apply_rgb: Process /usr/bin/gimp-...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gimp
Version: 18
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:26de16fe3c1d678c62ece7ec2fc...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-18 05:50 UTC by trennor
Modified: 2014-03-05 10:16 UTC (History)
4 users (show)

Fixed In Version: gimp-2.8.4-5.fc17
Clone Of:
: 1072883 (view as bug list)
Environment:
Last Closed: 2013-06-08 03:31:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (24.22 KB, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: cgroup (126 bytes, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: core_backtrace (945 bytes, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: dso_list (9.36 KB, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: environ (1.41 KB, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: limits (1.29 KB, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: maps (53.87 KB, text/plain)
2013-03-18 05:50 UTC, trennor
no flags Details
File: open_fds (357 bytes, text/plain)
2013-03-18 05:51 UTC, trennor
no flags Details
File: proc_pid_status (928 bytes, text/plain)
2013-03-18 05:51 UTC, trennor
no flags Details
File: smolt_data (2.61 KB, text/plain)
2013-03-18 05:51 UTC, trennor
no flags Details
File: var_log_messages (303 bytes, text/plain)
2013-03-18 05:51 UTC, trennor
no flags Details

Description trennor 2013-03-18 05:50:45 UTC
Description of problem:
Opened GIMP (General Image Manipulation Program) and loaded a png image into it, and it crashed. I have no screenshots. Reading back through the backtrace, it appears to be seg fault, 
though just what triggered it will be up to you people to find out. 

Version-Release number of selected component:
gimp-2.8.2-6.fc18

Additional info:
backtrace_rating: 4
cmdline:        gimp-2.8
crash_function: file_open_profile_apply_rgb
executable:     /usr/bin/gimp-2.8
kernel:         3.7.6-201.fc18.x86_64
uid:            1000

Truncated backtrace:
Thread no. 1 (7 frames)
 #0 file_open_profile_apply_rgb at file-open.c:685
 #1 file_open_handle_color_profile at file-open.c:732
 #2 file_open_image at file-open.c:207
 #3 gimp_imagefile_create_thumbnail at gimpimagefile.c:373
 #4 gimp_imagefile_create_thumbnail_weak at gimpimagefile.c:443
 #5 gimp_thumb_box_auto_thumbnail at gimpthumbbox.c:743
 #10 app_run at app.c:256

Potential duplicate: bug 767136

Comment 1 trennor 2013-03-18 05:50:48 UTC
Created attachment 711758 [details]
File: backtrace

Comment 2 trennor 2013-03-18 05:50:50 UTC
Created attachment 711759 [details]
File: cgroup

Comment 3 trennor 2013-03-18 05:50:52 UTC
Created attachment 711760 [details]
File: core_backtrace

Comment 4 trennor 2013-03-18 05:50:54 UTC
Created attachment 711761 [details]
File: dso_list

Comment 5 trennor 2013-03-18 05:50:55 UTC
Created attachment 711762 [details]
File: environ

Comment 6 trennor 2013-03-18 05:50:57 UTC
Created attachment 711763 [details]
File: limits

Comment 7 trennor 2013-03-18 05:50:59 UTC
Created attachment 711764 [details]
File: maps

Comment 8 trennor 2013-03-18 05:51:01 UTC
Created attachment 711765 [details]
File: open_fds

Comment 9 trennor 2013-03-18 05:51:03 UTC
Created attachment 711766 [details]
File: proc_pid_status

Comment 10 trennor 2013-03-18 05:51:05 UTC
Created attachment 711767 [details]
File: smolt_data

Comment 11 trennor 2013-03-18 05:51:07 UTC
Created attachment 711768 [details]
File: var_log_messages

Comment 12 Nils Philippsen 2013-03-18 11:46:00 UTC
Would you please attach the image file in question? Thanks!

Comment 13 Nils Philippsen 2013-03-18 11:48:43 UTC
BTW, please try to reproduce this with the current stable version of the package which is 2.8.4-1.fc18. Thanks!

Comment 14 Nils Philippsen 2013-03-18 11:57:00 UTC
The error happens here when dereferencing error, which is NULL:

--- 8< --- app/file/file-open.c -- file_open_profile_apply_rgb() ---
  if (! plug_in_icc_profile_apply_rgb (image, context, progress, run_mode,
                                       &error))
    {
      if (error->domain == GIMP_PLUG_IN_ERROR &&
          error->code   == GIMP_PLUG_IN_NOT_FOUND)
--- >8 -------------------------------------------------------------

--> plug_in_icc_profile_apply_rgb() returns FALSE, but doesn't set the error object, probably right here at the top of the function:

--- 8< --- app/plug-in/plug-in-icc-profile.c -- plug_in_icc_profile_apply_rgb() ---
  if (gimp_image_base_type (image) == GIMP_GRAY)
    return FALSE;
--- >8 ----------------------------------------------------------------------------

I suspect that the image is grayscale which would trigger this codepath. I'm consulting with upstream whether that's a bug in the caller (to not check for error != NULL) or the callee (to not set error in the case of an error).

Comment 15 Nils Philippsen 2013-03-18 12:47:44 UTC
I've committed a supposed fix for this issue, but before I build an updated package, I'd really like to test this with an image exhibiting the problem. Please attach it to this bug, thanks!

commit 096c636b67abd7967da645699948c2bd3f8273fb
Author:     Nils Philippsen <nils>
AuthorDate: Mon Mar 18 13:37:17 2013 +0100
Commit:     Nils Philippsen <nils>
CommitDate: Mon Mar 18 13:37:17 2013 +0100

    app: set error in case of error in ICC profile plug-in
    
    The function plug_in_icc_profile_apply_rgb() didn't set the error object
    when bailing out due to being called on a grayscale image, this could
    lead to crashes in callers which just checked the return value, but not
    whether or not an error had been set.

Comment 16 Fedora Update System 2013-06-04 10:09:59 UTC
gimp-2.8.4-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc17

Comment 17 Fedora Update System 2013-06-04 10:10:35 UTC
gimp-2.8.4-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc18

Comment 18 Fedora Update System 2013-06-04 10:11:11 UTC
gimp-2.8.4-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gimp-2.8.4-5.fc19

Comment 19 Fedora Update System 2013-06-05 02:35:44 UTC
Package gimp-2.8.4-5.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gimp-2.8.4-5.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10064/gimp-2.8.4-5.fc19
then log in and leave karma (feedback).

Comment 20 Fedora Update System 2013-06-08 03:31:43 UTC
gimp-2.8.4-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2013-06-12 02:36:07 UTC
gimp-2.8.4-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2013-06-14 02:31:58 UTC
gimp-2.8.4-5.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 23 Wayne Hammond 2014-01-05 16:22:50 UTC
This bug came up when I clicked on the link in the abrt report for a Gimp failure on my computer.

In the interest of adding useful information, this failure happens quite often on y computer and the cause seems to be trying to open a large image before the preview image loads in the "open file" menu item. Initially there is a folder image when the file is clicked on and if one uses a double click without actually seeing the image thumbnail, Gimp fails to load the file and quits. When the thumbnail appears, Gimp can open the file every time without incident.

Wayne


Note You need to log in before you can comment on or make changes to this bug.