Bug 1073907

Summary: Use DTD Public Identifier from source
Product: [Fedora] Fedora Reporter: Pavol Babinčák <pbabinca>
Component: libcompsAssignee: Jindrich Luza <jluza>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: jluza
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libcomps-0.1.6-10.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-15 12:22:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Minimal reproducer
none
Input yum groups file none

Description Pavol Babinčák 2014-03-07 13:10:54 UTC
Created attachment 871890 [details]
Minimal reproducer

Description of problem:
I'm loading yum groups XML and then saving it with python bindings. DTD Formal Public Identifier in generated XML file always starts with -//Red Hat, Inc.// regardless of source XML.

Version-Release number of selected component (if applicable):
libcomps-0.1.6-3.fc21.x86_64
python-libcomps-0.1.6-3.fc21.x86_64
python-2.7.5-11.fc20.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Download attached p.py and centosdtd.xml
2. Run python p.py
3. Run diff -u centosdtd.xml generated.xml

Actual results:
Diff output shows:
-<!DOCTYPE comps PUBLIC "-//CentOS//DTD Comps info//EN" "comps.dtd">
+<!DOCTYPE comps PUBLIC "-//Red Hat, Inc.//DTD Comps info//EN" "comps.dtd">


Expected results:
Original DTD Public identifier should be used.

Additional info:

Comment 1 Pavol Babinčák 2014-03-07 13:11:28 UTC
Created attachment 871891 [details]
Input yum groups file

Comment 2 Jindrich Luza 2014-03-10 14:52:17 UTC
Cant reproduce.
Generated xml contains "-//Red Hat, Inc.//DTD Comps info//EN" "comps.dtd" in DOCTYPE. I'm not sure I did something that could fixed wrong dtd path during I fixed other bugs (most probably not). But this bug will be fixed in next release for sure.

Comment 3 Jindrich Luza 2014-03-10 15:12:07 UTC
Sorry for misleading conclusion. I read "should always start". So it's really the bug.

Comment 4 Jindrich Luza 2014-04-15 12:22:11 UTC
fixed in libcomps-0.1.6-10.fc21.x86_64

Comment 5 Fedora Update System 2014-04-15 13:09:47 UTC
libcomps-0.1.6-10.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libcomps-0.1.6-10.fc20

Comment 6 Fedora Update System 2014-04-24 07:32:30 UTC
libcomps-0.1.6-10.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.