Bug 1073907 - Use DTD Public Identifier from source
Summary: Use DTD Public Identifier from source
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libcomps
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Jindrich Luza
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-07 13:10 UTC by Pavol Babinčák
Modified: 2014-04-24 07:32 UTC (History)
1 user (show)

Fixed In Version: libcomps-0.1.6-10.fc20
Clone Of:
Environment:
Last Closed: 2014-04-15 12:22:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Minimal reproducer (122 bytes, text/x-python)
2014-03-07 13:10 UTC, Pavol Babinčák
no flags Details
Input yum groups file (510 bytes, text/xml)
2014-03-07 13:11 UTC, Pavol Babinčák
no flags Details

Description Pavol Babinčák 2014-03-07 13:10:54 UTC
Created attachment 871890 [details]
Minimal reproducer

Description of problem:
I'm loading yum groups XML and then saving it with python bindings. DTD Formal Public Identifier in generated XML file always starts with -//Red Hat, Inc.// regardless of source XML.

Version-Release number of selected component (if applicable):
libcomps-0.1.6-3.fc21.x86_64
python-libcomps-0.1.6-3.fc21.x86_64
python-2.7.5-11.fc20.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Download attached p.py and centosdtd.xml
2. Run python p.py
3. Run diff -u centosdtd.xml generated.xml

Actual results:
Diff output shows:
-<!DOCTYPE comps PUBLIC "-//CentOS//DTD Comps info//EN" "comps.dtd">
+<!DOCTYPE comps PUBLIC "-//Red Hat, Inc.//DTD Comps info//EN" "comps.dtd">


Expected results:
Original DTD Public identifier should be used.

Additional info:

Comment 1 Pavol Babinčák 2014-03-07 13:11:28 UTC
Created attachment 871891 [details]
Input yum groups file

Comment 2 Jindrich Luza 2014-03-10 14:52:17 UTC
Cant reproduce.
Generated xml contains "-//Red Hat, Inc.//DTD Comps info//EN" "comps.dtd" in DOCTYPE. I'm not sure I did something that could fixed wrong dtd path during I fixed other bugs (most probably not). But this bug will be fixed in next release for sure.

Comment 3 Jindrich Luza 2014-03-10 15:12:07 UTC
Sorry for misleading conclusion. I read "should always start". So it's really the bug.

Comment 4 Jindrich Luza 2014-04-15 12:22:11 UTC
fixed in libcomps-0.1.6-10.fc21.x86_64

Comment 5 Fedora Update System 2014-04-15 13:09:47 UTC
libcomps-0.1.6-10.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libcomps-0.1.6-10.fc20

Comment 6 Fedora Update System 2014-04-24 07:32:30 UTC
libcomps-0.1.6-10.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.