Bug 1077746
| Summary: | Review Request: libappstream-glib - Library for AppStream metadata | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Hughes <rhughes> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-18 17:58:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Hughes
2014-03-18 14:00:34 UTC
naming: ok
sources: ok
c8f2bb33d2615be39eed28969173a12e appstream-glib-0.1.0.tar.xz
licensing: ok
builds/installs: ok
scriptlets: ok
looks good in general, some mostly smaller items:
1. SHOULD use arch'd dependency in -devel subpkg, use
Requires: %{name}%{?_isa} = %{version}-%{release}
instead of
Requires: %{name} = %{version}-%{release}
2. SHOULD omit deprecated tags
%defattr
3. SHOULD up build dep
BuildRequires: glib2-devel >= 2.16.1
to
BuildRequires: glib2-devel >= 2.39
build fails on f20 using glib2-2.28, with:
./.libs/libappstream-glib.so: error: undefined reference to 'g_str_tokenize_and_fold'
which I believe is new in 2.39 (I could be wrong though)
4. SHOULD track library soname in %files, I'd prefer:
%{_libdir}/libappstream-glib.so.1*
instead of:
%{_libdir}/*libappstream-glib*.so.*
which avoids the possibility of surprise soname bumps.
5. SHOULD omit unused macro:
%define alphatag .20140318git
As these are not blockers, APPROVED
(though I'd prefer you consider addressing these prior to doing any official builds in koji).
> 1. SHOULD use arch'd dependency in -devel subpkg, use > Requires: %{name}%{?_isa} = %{version}-%{release} > instead of > Requires: %{name} = %{version}-%{release} Fixed. > 2. SHOULD omit deprecated tags > %defattr Fixed. > 3. SHOULD up build dep > BuildRequires: glib2-devel >= 2.16.1 > to > BuildRequires: glib2-devel >= 2.39 Fixed, and good catch. > 4. SHOULD track library soname in %files, I'd prefer: > %{_libdir}/libappstream-glib.so.1* > instead of: > %{_libdir}/*libappstream-glib*.so.* Fixed. > 5. SHOULD omit unused macro: > %define alphatag .20140318git Fixed. Thanks for the speedy review. New Package SCM Request ======================= Package Name: libappstream-glib Short Description: Library for AppStream metadata Owners: rhughes Branches: f20 InitialCC: rhughes Git done (by process-git-requests). Build fine, thanks all! |