Bug 1077746 - Review Request: libappstream-glib - Library for AppStream metadata
Review Request: libappstream-glib - Library for AppStream metadata
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Rex Dieter
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-18 10:00 EDT by Richard Hughes
Modified: 2014-03-18 13:58 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-03-18 13:58:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Richard Hughes 2014-03-18 10:00:34 EDT
Spec URL: http://people.freedesktop.org/~hughsient/temp/libappstream-glib.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/libappstream-glib-0.1.0-1.fc20.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6645564
Description:

This library provides GObjects and helper methods to make it easy to read and write AppStream metadata. It also provides a simple DOM implementation that makes it easy to edit nodes and convert to and from the standardized XML representation.

This library will be used in gnome-software (already in fedora) post 3.12, appdata-tools (already in fedora) for the next release and createrepo_as (not yet in fedora).

Fedora Account System Username: rhughes

rpmbuild warnings:

libappstream-glib.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal
libappstream-glib.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libappstream-glib-devel.x86_64: W: spelling-error Summary(en_US) appstream -> app stream, app-stream, upstream
libappstream-glib-devel.x86_64: W: spelling-error %description -l en_US appstream -> app stream, app-stream, upstream
libappstream-glib.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal
libappstream-glib.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
4 packages and 1 specfiles checked; 0 errors, 6 warnings.

(all false positives, "metadata" is of course a correct word, and "AppStream" is the name of the XML standard)

Comments and suggestions very welcome, thanks.
Comment 1 Rex Dieter 2014-03-18 11:08:27 EDT
naming: ok

sources: ok
c8f2bb33d2615be39eed28969173a12e  appstream-glib-0.1.0.tar.xz

licensing: ok

builds/installs: ok

scriptlets: ok


looks good in general, some mostly smaller items:

1. SHOULD use arch'd dependency in -devel subpkg, use
Requires: %{name}%{?_isa} = %{version}-%{release}
instead of
Requires: %{name} = %{version}-%{release}

2.  SHOULD omit deprecated tags
%defattr

3. SHOULD up build dep
BuildRequires: glib2-devel >= 2.16.1
to
BuildRequires: glib2-devel >= 2.39

build fails on f20 using glib2-2.28, with:
./.libs/libappstream-glib.so: error: undefined reference to 'g_str_tokenize_and_fold'
which I believe is new in 2.39  (I could be wrong though)

4. SHOULD track library soname in %files, I'd prefer:
%{_libdir}/libappstream-glib.so.1*
instead of:
%{_libdir}/*libappstream-glib*.so.*

which avoids the possibility of surprise soname bumps.

5. SHOULD omit unused macro:
%define alphatag                .20140318git


As these are not blockers, APPROVED

(though I'd prefer you consider addressing these prior to doing any official builds in koji).
Comment 2 Richard Hughes 2014-03-18 11:50:49 EDT
> 1. SHOULD use arch'd dependency in -devel subpkg, use
> Requires: %{name}%{?_isa} = %{version}-%{release}
> instead of
> Requires: %{name} = %{version}-%{release}

Fixed.

> 2.  SHOULD omit deprecated tags
> %defattr

Fixed.

> 3. SHOULD up build dep
> BuildRequires: glib2-devel >= 2.16.1
> to
> BuildRequires: glib2-devel >= 2.39

Fixed, and good catch.

> 4. SHOULD track library soname in %files, I'd prefer:
> %{_libdir}/libappstream-glib.so.1*
> instead of:
> %{_libdir}/*libappstream-glib*.so.*

Fixed.

> 5. SHOULD omit unused macro:
> %define alphatag                .20140318git

Fixed.

Thanks for the speedy review.
Comment 3 Richard Hughes 2014-03-18 11:51:37 EDT
New Package SCM Request
=======================
Package Name: libappstream-glib
Short Description: Library for AppStream metadata
Owners: rhughes
Branches: f20
InitialCC: rhughes
Comment 4 Gwyn Ciesla 2014-03-18 12:33:28 EDT
Git done (by process-git-requests).
Comment 5 Richard Hughes 2014-03-18 13:58:19 EDT
Build fine, thanks all!

Note You need to log in before you can comment on or make changes to this bug.