Bug 1077935
| Summary: | Review Request: mingw-taglib - Audio Meta-Data Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David King <amigadave> |
| Component: | Package Review | Assignee: | Jerry James <loganjerry> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-mingw, loganjerry, package-review, ulatekh |
| Target Milestone: | --- | Flags: | loganjerry:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | mingw-taglib-1.9.1-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-06 03:33:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David King
2014-03-18 21:45:51 UTC
*** Bug 970416 has been marked as a duplicate of this bug. *** I will take this review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - The license tag is incorrect. This is a problem with the taglib spec file, too. It should be "LGPLv2 and MPLv1.1". See: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses - If the package is under multiple licenses, the licensing breakdown must be documented in the spec. See: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 39669760 bytes in 2618 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). - Also, please check on the following rpmlint messages: mingw-taglib.src: W: strange-permission taglib-snapshot.sh 0775L mingw-taglib.src:29: W: macro-in-comment %_libdir mingw-taglib.src: W: patch-not-applied Patch1: taglib-1.5b1-multilib.patch mingw-taglib.src: W: invalid-url Source0: https://github.com/downloads/taglib/taglib/taglib-1.9.1.tar.gz HTTP Error 404: Not Found ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: mingw32-taglib-1.9.1-2.fc21.noarch.rpm mingw64-taglib-1.9.1-2.fc21.noarch.rpm mingw-taglib-1.9.1-2.fc21.src.rpm mingw32-taglib.noarch: W: invalid-license MPL mingw32-taglib.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libtag_c.dll.a mingw32-taglib.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libtag.dll.a mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/xiphcomment.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/asffile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/commentsframe.h mingw32-taglib.noarch: E: script-without-shebang /usr/i686-w64-mingw32/sys-root/mingw/bin/taglib-config.cmd mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tfilestream.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/xingheader.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/apefooter.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/taglib.pc mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/aiffproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tlist.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v1genres.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2footer.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/aifffile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/modfilebase.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2framefactory.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tiostream.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/flacpicture.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/urllinkframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4properties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/taglib_config.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tbytevector.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tpropertymap.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/modfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/textidentificationframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/asftag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tag_c.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tbytevectorlist.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/ownershipframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/oggpage.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2frame.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/s3mproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/popularimeterframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4atom.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/privateframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/taglib_c.pc mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/wavproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/taglib.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/apefile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/wavpackfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/rifffile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/flacmetadatablock.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/attachedpictureframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/trueaudioproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4file.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/asfpicture.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mpcproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/uniquefileidentifierframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/unsynchronizedlyricsframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/apetag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/apeitem.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mpcfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/xmfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/itproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libtag_c.dll.a mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/speexfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/modtag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tbytevectorstream.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4coverart.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/speexproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/oggflacfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/fileref.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2tag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/infotag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tstring.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/flacfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/modproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tmap.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libtag.dll.a mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/vorbisfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/relativevolumeframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mpegfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/trefcounter.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mpegproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/apeproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/vorbisproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/asfproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/opusproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2header.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/taglib_export.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/wavpackproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mpegheader.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/itfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/flacproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4tag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/s3mfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/generalencapsulatedobjectframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/unknownframe.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/mp4item.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v1tag.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tstringlist.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/asfattribute.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/trueaudiofile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2synchdata.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/id3v2extendedheader.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/oggpageheader.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/opusfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/xmproperties.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/oggfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/wavfile.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/tdebuglistener.h mingw32-taglib.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/taglib/audioproperties.h mingw32-taglib.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-taglib.noarch: W: invalid-license MPL mingw64-taglib.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libtag.dll.a mingw64-taglib.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libtag_c.dll.a mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/fileref.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/unknownframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/flacfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mpcfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/apetag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4tag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/trefcounter.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/vorbisproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/taglib_export.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/asftag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/rifffile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mpegfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/itproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libtag.dll.a mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4atom.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4coverart.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tmap.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/speexfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v1tag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/modfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/taglib.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4file.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/trueaudiofile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/apeproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/taglib_config.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/taglib_c.pc mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/xingheader.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/unsynchronizedlyricsframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v1genres.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/opusfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tiostream.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tstringlist.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/ownershipframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mpegproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2framefactory.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/popularimeterframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/infotag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mpcproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/commentsframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libtag_c.dll.a mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tfilestream.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/oggfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/audioproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2extendedheader.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/modproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/s3mfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tbytevectorstream.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tdebuglistener.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/attachedpictureframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/wavpackfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/itfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/asfattribute.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/asffile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/flacpicture.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/flacmetadatablock.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2header.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/s3mproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/wavproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/apeitem.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2footer.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tpropertymap.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/taglib.pc mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4properties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tag_c.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/textidentificationframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/vorbisfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2synchdata.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/modtag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/wavpackproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2frame.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/apefooter.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/id3v2tag.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/asfproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/opusproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/oggpage.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/trueaudioproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/relativevolumeframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/asfpicture.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/oggpageheader.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/xiphcomment.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/wavfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/aifffile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mpegheader.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/flacproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/privateframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/xmfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/modfilebase.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tstring.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tbytevector.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/speexproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/xmproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tlist.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/tbytevectorlist.h mingw64-taglib.noarch: E: script-without-shebang /usr/x86_64-w64-mingw32/sys-root/mingw/bin/taglib-config.cmd mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/uniquefileidentifierframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/aiffproperties.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/urllinkframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/generalencapsulatedobjectframe.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/oggflacfile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/apefile.h mingw64-taglib.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/taglib/mp4item.h mingw64-taglib.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-taglib.src: W: invalid-license MPL mingw-taglib.src: W: strange-permission taglib-snapshot.sh 0775L mingw-taglib.src:29: W: macro-in-comment %_libdir mingw-taglib.src: W: patch-not-applied Patch1: taglib-1.5b1-multilib.patch mingw-taglib.src: W: invalid-url Source0: https://github.com/downloads/taglib/taglib/taglib-1.9.1.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 6 errors, 213 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw64-taglib mingw32-taglib mingw64-taglib.noarch: W: invalid-license MPL mingw64-taglib.noarch: E: script-without-shebang /usr/x86_64-w64-mingw32/sys-root/mingw/bin/taglib-config.cmd mingw32-taglib.noarch: W: invalid-license MPL mingw32-taglib.noarch: E: script-without-shebang /usr/i686-w64-mingw32/sys-root/mingw/bin/taglib-config.cmd 2 packages and 0 specfiles checked; 2 errors, 2 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/1077935-mingw-taglib/srpm/mingw-taglib.spec 2014-04-24 13:21:38.179429900 -0600 +++ /home/jamesjer/1077935-mingw-taglib/srpm-unpacked/mingw-taglib.spec 2014-02-11 06:22:22.000000000 -0700 @@ -4,4 +4,6 @@ %bcond_without tests +%bcond_without doc +%global apidocdir __api-doc_fedora Name: mingw-%{_basename} @@ -10,13 +12,25 @@ Release: 2%{?dist} -License: LGPLv2 and MPLv1.1 +License: LGPLv2 and MPL +#URL: http://launchpad.net/taglib URL: http://taglib.github.com/ -Source0: https://github.com/%{_basename}/%{_basename}/releases/download/v%{version}/%{_basename}-%{version}.tar.gz +%if 0%{?snap:1} +Source0: %{_basename}-%{version}-%{snap}.tar.gz +%else +Source0: https://github.com/downloads/taglib/taglib/%{_basename}-%{version}.tar.gz +%endif +# The snapshot tarballs generated with the following script: +Source1: taglib-snapshot.sh Patch0: taglib-mingw.patch -Patch1: taglib-1.5rc1-multilib.patch + +# http://bugzilla.redhat.com/343241 +# try 1, use pkg-config +Patch1: taglib-1.5b1-multilib.patch +# try 2, kiss omit -L%_libdir +Patch2: taglib-1.5rc1-multilib.patch ## upstream patches -Patch1002: 0002-Fixed-ABI-breakage-in-TagLib-String.patch -Patch1003: 0003-Rewrote-ByteVector-replace-simpler.patch +Patch1002: 0002-Fixed-ABI-breakage-in-TagLib-String.patch +Patch1003: 0003-Rewrote-ByteVector-replace-simpler.patch BuildArch: noarch @@ -25,4 +39,5 @@ BuildRequires: mingw32-gcc BuildRequires: mingw32-gcc-c++ +BuildRequires: mingw32-binutils BuildRequires: mingw32-zlib @@ -30,10 +45,16 @@ BuildRequires: mingw64-gcc BuildRequires: mingw64-gcc-c++ +BuildRequires: mingw64-binutils BuildRequires: mingw64-zlib -BuildRequires: cmake +BuildRequires: cmake +BuildRequires: pkgconfig %if %{with tests} #BuildRequires: cppunit-devel %endif +%if %{with doc} +BuildRequires: doxygen +BuildRequires: graphviz +%endif %description @@ -44,7 +65,7 @@ -%package -n mingw32-%{_basename} -Summary: MinGW Windows version of TagLib for the win32 target -Group: Development/Libraries +%package -n mingw32-%{_basename} +Summary: MinGW Windows version of TagLib for the win32 target +Group: Development/Libraries %description -n mingw32-%{_basename} @@ -53,7 +74,16 @@ This is the MinGW version, built for the win32 target. -%package -n mingw64-%{_basename} -Summary: MinGW Windows version of TagLib for the win64 target -Group: Development/Libraries +%package -n mingw32-%{_basename}-static +Summary: MinGW Windows version of TagLib for the win32 target +Group: Development/Libraries +Requires: mingw32-%{_basename} = %{version}-%{release} + +%description -n mingw32-%{_basename}-static +Static libraries for the MinGW version of %{_basename}, built for +the win32 target. + +%package -n mingw64-%{_basename} +Summary: MinGW Windows version of TagLib for the win64 target +Group: Development/Libraries %description -n mingw64-%{_basename} @@ -62,4 +92,13 @@ This is the MinGW version, built for the win64 target. +%package -n mingw64-%{_basename}-static +Summary: MinGW Windows version of TagLib for the win64 target +Group: Development/Libraries +Requires: mingw64-%{_basename} = %{version}-%{release} + +%description -n mingw64-%{_basename}-static +Static libraries for the MinGW version of %{_basename}, built for +the win64 target. + %{?mingw_debug_package} @@ -67,12 +106,14 @@ %prep -%setup -q -n %{_basename}-%{version} +%setup -q -n %{_basename}-%{version}%{?pre} %patch0 -p1 -%patch1 -p1 -b .multilib + +# patch1 not applied +## omit for now +%patch2 -p1 -b .multilib %patch1002 -p1 -b .0002 %patch1003 -p1 -b .0003 - %build %{mingw_cmake} \ @@ -81,8 +122,47 @@ %{mingw_make} %{?_smp_mflags} +rm -rf build_win32_static +mkdir build_win32_static +pushd build_win32_static +%{mingw32_cmake} \ + %{?with_tests:-DBUILD_TESTS:BOOL=ON} \ + -DENABLE_STATIC:BOOL=ON \ + .. +%{mingw32_make} %{?_smp_mflags} +popd + +rm -rf build_win64_static +mkdir build_win64_static +pushd build_win64_static +%{mingw64_cmake} \ + %{?with_tests:-DBUILD_TESTS:BOOL=ON} \ + -DENABLE_STATIC:BOOL=ON \ + .. +%{mingw64_make} %{?_smp_mflags} +popd + +%if %{with doc} +%{mingw_make} docs +%endif + %install %{mingw_make} install/fast DESTDIR=%{buildroot} +pushd build_win32_static +%{mingw32_make} install/fast DESTDIR=%{buildroot} +popd + +pushd build_win64_static +%{mingw64_make} install/fast DESTDIR=%{buildroot} +popd + +%if %{with doc} +rm -fr %{apidocdir} ; mkdir %{apidocdir} +cp -a build_win32/doc/html/ %{apidocdir}/ +ln -s html/index.html %{apidocdir} +find %{apidocdir} -name '*.md5' | xargs rm -fv +%endif + %files -n mingw32-%{_basename} @@ -90,4 +170,5 @@ %{mingw32_bindir}/libtag.dll %{mingw32_bindir}/libtag_c.dll +%doc examples %{mingw32_bindir}/taglib-config.cmd %{mingw32_includedir}/taglib/ @@ -96,4 +177,11 @@ %{mingw32_libdir}/pkgconfig/taglib.pc %{mingw32_libdir}/pkgconfig/taglib_c.pc +%if %{with doc} +%doc %{apidocdir}/* +%endif + +%files -n mingw32-%{_basename}-static +%{mingw32_libdir}/libtag.a +%{mingw32_libdir}/libtag_c.a %files -n mingw64-%{_basename} @@ -101,4 +189,5 @@ %{mingw64_bindir}/libtag.dll %{mingw64_bindir}/libtag_c.dll +%doc examples %{mingw64_bindir}/taglib-config.cmd %{mingw64_includedir}/taglib/ @@ -107,8 +196,15 @@ %{mingw64_libdir}/pkgconfig/taglib.pc %{mingw64_libdir}/pkgconfig/taglib_c.pc +%if %{with doc} +%doc %{apidocdir}/* +%endif + +%files -n mingw64-%{_basename}-static +%{mingw64_libdir}/libtag.a +%{mingw64_libdir}/libtag_c.a %changelog -* Tue Mar 18 2014 David King <amigadave> 1.9.1-2 +* Tue Feb 11 2014 David King <amigadave> 1.9.1-2 - Update to 1.9.1-2 from Fedora Requires -------- mingw64-taglib (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libstdc++-6.dll) mingw64(libtag.dll) mingw64(msvcrt.dll) mingw64(zlib1.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config mingw32-taglib (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libstdc++-6.dll) mingw32(libtag.dll) mingw32(msvcrt.dll) mingw32(zlib1.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config Provides -------- mingw64-taglib: mingw64(libtag.dll) mingw64(libtag_c.dll) mingw64-taglib mingw32-taglib: mingw32(libtag.dll) mingw32(libtag_c.dll) mingw32-taglib Source checksums ---------------- https://github.com/taglib/taglib/releases/download/v1.9.1/taglib-1.9.1.tar.gz : CHECKSUM(SHA256) this package : 72d371cd1419a87ae200447a53bff2be219283071e80fd12337928cc967dc71a CHECKSUM(SHA256) upstream package : 72d371cd1419a87ae200447a53bff2be219283071e80fd12337928cc967dc71a Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1077935 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Spec URL: http://amigadave.fedorapeople.org/mingw-taglib.spec SRPM URL: http://amigadave.fedorapeople.org/mingw-taglib-1.9.1-2.fc21.src.rpm Ugh, sorry about the spec/SRPM mixup. I uploaded a new version of both, with all the issues that you mentioned fixed (note the fc21 in the SRPM URL). After a bit of investigation, I discovered that the license was actually LGPLv2 _or_ MPLv1.1, not "and": https://github.com/taglib/taglib/commit/5b03541038982eb76a3954e4383ad4a1f89dc279 I filed a bug against the native package about the license problem: bug 1091089. Hmmm, now the build is failing:
Building CXX object tests/CMakeFiles/test_runner.dir/test_synchdata.cpp.obj
cd /builddir/build/BUILD/taglib-1.9.1/build_win32/tests && /usr/bin/i686-w64-mingw32-g++ -DHAVE_CONFIG_H -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -Wall @CMakeFiles/test_runner.dir/includes_CXX.rsp -o CMakeFiles/test_runner.dir/test_synchdata.cpp.obj -c /builddir/build/BUILD/taglib-1.9.1/tests/test_synchdata.cpp
/builddir/build/BUILD/taglib-1.9.1/tests/test_map.cpp:1:45: fatal error: cppunit/extensions/HelperMacros.h: No such file or directory
#include <cppunit/extensions/HelperMacros.h>
^
compilation terminated.
make[2]: *** [tests/CMakeFiles/test_runner.dir/test_map.cpp.obj] Error 1
Hmm, it built fine for me locally in mock, and as a scratch build in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6775928 You don't happen to have cppunit-devel installed, or have enabled the tests in some way? I'm just running "fedora-review -b 1077935 -m fedora-rawhide-x86_64", which builds in mock. The weird thing is that it worked earlier today. I'm afraid I'm out of time to look into this tonight. I'll look at it again in the morning. I snuck a little more time in after all. :-) I just tried it on a different machine, and it builds without trouble. I don't know what happened on that first machine. Anyway, all of the issues appear to be fixed, so this package is APPROVED. New Package SCM Request ======================= Package Name: mingw-taglib Short Description: Audio Meta-Data Library Owners: amigadave Branches: f20 InitialCC: Thanks for your time on the review Jerry! Please let me know if you have any more reviews that you would like to swap, as I learnt quite a bit from the subunit and balloontip reviews, and look forward to more like them. Git done (by process-git-requests). mingw-taglib-1.9.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-taglib-1.9.1-3.fc20 mingw-taglib-1.9.1-3.fc20 has been pushed to the Fedora 20 testing repository. mingw-taglib-1.9.1-3.fc20 has been pushed to the Fedora 20 stable repository. |