| Summary: | Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | T.C. Hollingsworth <tchollingsworth> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gregor, mrunge, msrb, package-review, panemade, tchollingsworth |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | js-jquery-2.1.3-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-19 14:08:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 977125, 977141, 1078364 | ||
| Bug Blocks: | 1078359, 603937, 858027, 959946, 974725, 1006575, 1008083, 1078903, 1086729, 1103414 | ||
|
Description
T.C. Hollingsworth
2014-03-19 16:46:26 UTC
*** Bug 857992 has been marked as a duplicate of this bug. *** Ready for review now. Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-1.fc20.src.rpm I've now fixed an annoying bug in grunt and can drop the hack I added in %prep to make it build. This now requires the most recent nodejs-grunt to build. Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-2.fc20.src.rpm Fixed based on feedback from the js-sizzle review: Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-3.fc20.src.rpm * Tue Jun 03 2014 T.C. Hollingsworth <tchollingsworth@gmail.com> - 1.11.1-3 - follow the github SourceURL guidelines Mock build fails like js-query:
+ ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.js /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.js
+ ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.js /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.min.js
+ ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.map /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.min.map
ln: failed to access '/builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.map': No such file or directory
エラー: /var/tmp/rpm-tmp.G748eQ の不正な終了ステータス (%install)
RPM ビルドのエラー:
/var/tmp/rpm-tmp.G748eQ の不正な終了ステータス (%install)
Child return code was: 1
Something (dep?) missing?
I was missing the '-s' argument to 'ln' in a few places. But in further testing I discovered that source maps don't work with those particular symlinks, and they really seem to be overkill, so I just removed them instead. -- Spec: https://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-4.fc20.src.rpm * Tue Oct 21 2014 T.C. Hollingsworth <tchollingsworth@gmail.com> - 1.11.1-4 - drop unneccessary symlinks Review: + mock build is successful for f22. + rpmlint output on rpms gave js-jquery1.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry js-jquery1.noarch: W: spelling-error %description -l en_US extensibility -> sensibility, extensible js-jquery1.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry js-jquery1.src: W: spelling-error %description -l en_US extensibility -> sensibility, extensible 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + Source verified with upstream as (sha256sum) srpm tarball :ba7e5a7fb659691ec2bb23c1a949c99d47633dff48dab774702ae1d9cfddda8b upstream tarball :ba7e5a7fb659691ec2bb23c1a949c99d47633dff48dab774702ae1d9cfddda8b + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines. APPROVED. New Package SCM Request ======================= Package Name: js-jquery1 Short Description: JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers Upstream URL: https://jquery.com/ Owners: patches jamielinux Branches: f21 f20 f19 epel7 el6 el5 InitialCC: Git done (by process-git-requests). not built on koji yet?? ping? :) Ping2? Sorry for the delay, I was really waiting for the trio of packages to push everything out to all Fedora releases, but I really should have built this for rawhide immediately sorry. I would build it right now, but dist-git is down. :-( In the meantime, here's the latest upstream release: -- Spec: https://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery1-1.11.2-1.fc20.src.rpm * Thu Feb 19 2015 T.C. Hollingsworth <tchollingsworth@gmail.com> - 1.11.2-1 - new upstream release 1.11.2 http://blog.jquery.com/2014/12/18/jquery-1-11-2-and-2-1-3-released-safari-fail-safe-edition/ Built for rawhide and branched: http://koji.fedoraproject.org/koji/packageinfo?packageID=19341 Congrats js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 js-jquery-2.1.3-1.el6, js-jquery1-1.11.2-2.el6, js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been pushed to the Fedora EPEL 6 stable repository. js-jquery-2.1.3-1.el7, js-sizzle-2.1.1-1.jquery.2.1.2.el7, js-jquery1-1.11.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. js-jquery-2.1.3-1.fc21, js-sizzle-2.1.1-1.jquery.2.1.2.fc21, js-jquery1-1.11.2-2.fc21 has been pushed to the Fedora 21 stable repository. js-jquery-2.1.3-1.fc20, js-jquery1-1.11.2-2.fc20, js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been pushed to the Fedora 20 stable repository. |