Bug 1078524

Summary: Use system double-conversion instead of bundled one
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: qt5-qtdeclarativeAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jgrulich, jreznik, kevin, nalimilan, projects.rg, rdieter, rnovacek, than
Target Milestone: ---Keywords: FutureFeature, Patch, Reopened
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-21 15:40:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 504493    
Attachments:
Description Flags
Use system double-conversion instead of bundled one none

Description Ville Skyttä 2014-03-19 20:05:13 UTC
Build tested fix attached, want me to push and build this for devel?

Comment 1 Ville Skyttä 2014-03-19 20:05:19 UTC
Created attachment 876605 [details]
Use system double-conversion instead of bundled one

Comment 2 Rex Dieter 2014-03-20 17:48:00 UTC
I like, but I'd prefer to keep the the related patches for the bundled code where system copies are not yet available (ie, EPEL).

I'll adapt this to suit.

Comment 3 Milan Bouchet-Valat 2015-01-01 12:17:31 UTC
Sure, it would even be useful for me. I've requested it on bug 1040027.

Comment 4 Johnny Robeson 2015-01-02 00:08:09 UTC
added to epel testing now: https://bugzilla.redhat.com/show_bug.cgi?id=1177998
please give karma: https://admin.fedoraproject.org/updates/double-conversion-2.0.1-3.el7

Comment 5 Jaroslav Reznik 2015-03-03 16:59:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 6 Rex Dieter 2016-05-20 13:29:38 UTC
Sorry for the delay, was looking at the attached patch for inclusion now, but it seems to be missing  qtdeclarative-opensource-src-5.2.1-system-doubleconv.patch

Comment 7 Ville Skyttä 2016-05-20 15:56:40 UTC
(In reply to Rex Dieter from comment #6)
> it seems to be missing 
> qtdeclarative-opensource-src-5.2.1-system-doubleconv.patch

It's not missing, Bugzilla's patch viewer just eats patches for breakfast (there's at least bug 554878 reported for this).

Use the link in the Attachments box:
 https://bugzilla.redhat.com/attachment.cgi?id=876605

Comment 8 Rex Dieter 2016-05-20 16:01:07 UTC
Thanks, I see it now.  I'll integrate it soon (today hopefully)

Comment 9 Rex Dieter 2016-05-20 16:55:53 UTC
%changelog
* Fri May 20 2016 Rex Dieter <rdieter> - 5.6.0-9
- Use system double-conversion (#1078524)

Comment 10 Raphael Groner 2016-05-20 20:04:21 UTC
The patch broke ABI for both python-qt5¹ and qupzilla².

¹ http://koji.fedoraproject.org/koji/taskinfo?taskID=14191737
² http://koji.fedoraproject.org/koji/taskinfo?taskID=14192034

Comment 11 Rex Dieter 2016-05-20 20:12:11 UTC
ild/moc_kwalletplugin.cpp
/usr/lib/gcc/x86_64-redhat-linux/6.1.1/../../../../lib64/libQt5WebEngineCore.so: undefined reference to `pci_init'

Pretty sure that is unrelated to this change, but I'll look closers later tonight

Comment 12 Rex Dieter 2016-05-21 15:40:59 UTC
I've confirmed that symbol comes from pciutils, for which a new version landed recently in rawhide,

I commented on
https://bugzilla.redhat.com/show_bug.cgi?id=1337735#c5

closing here.


In the meantime, I'll probably submit a new qtwebengine build that may fix this in the short term, but that won't fix the pciutils ABI break either.