Bug 1079733 (perl-Catalyst-Plugin-Redirect)
| Summary: | Review Request: perl-Catalyst-Plugin-Redirect - Redirect for Catalyst used easily is offered | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sven Nierlein <Sven.Nierlein> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, rc040203 |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.02-4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-28 20:37:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1069988 | ||
|
Description
Sven Nierlein
2014-03-23 15:15:51 UTC
Package is basically OK, but a missing BR: perl(strict). i.e. please add BuildRequires: perl(strict) Besides this, similar remarks wrt. rhel as with your other packages also apply here. spec and src rpm updated. BR:s added and implemented remarks from the other packages. I updated the spec file according to comments from the related bugs and uploaded new files here: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect-0.02-1.fc21.noarch.rpm (In reply to Sven Nierlein from comment #4) > Source RPM: > http://nierlein.com/fedora/2014-04-06/perl-LWP-Protocol-connect-6.06-1.fc21. > src.rpm Wrong BZ? (In reply to Sven Nierlein from comment #3) > http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect-0.02-1. > fc21.noarch.rpm Please increment the NEVR each time you change your package. This review isn't going anywhere unless you finally do so. ok, sorry, this is my first review. I will update the packages and do a new upload. So what would be the correct way to continue, my idea is, that we have a correct spec file at the end of the review process. So i would increase the NEVR, update the last changelog entry (date and version) and upload new files. new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-Redirect.spec i only changed the release number. Missing [MUSTFIX]: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) I update the spec file and added the compat requires and more BRs according to cpanspec. New files are here: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Redirect-0.02-3.fc21.src.rpm Closer but still no cigar: Please remove the "R: perl(Catalyst)". It's redundant to what rpm detects automatically. Ok, thanks for your feedback, updated files are located here: http://nierlein.com/fedora/2014-07-25/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-07-25/perl-Catalyst-Plugin-Redirect-0.02-4.fc22.src.rpm Everything's OK, now. APPROVED New Package SCM Request ======================= Package Name: perl-Catalyst-Plugin-Redirect Short Description: Catalyst::Plugin::Redirect is a Catalyst Plugin that provides redirects. Owners: sni Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). build and upload completed |