Spec URL: http://nierlein.com/fedora/perl-Catalyst-Plugin-Redirect.spec SRPM URL: http://nierlein.com/fedora/perl-Catalyst-Plugin-Redirect-0.02-1.fc21.src.rpm Description: Catalyst::Plugin::Redirect is a Catalyst Plugin that provides redirects. Fedora Account System Username: sni Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6665257 Since this is my first review request, docs state that i should ask for a sponsor. This perl module is required to proceed in #1069988 Related review requests: #1079718, #1079732
Package is basically OK, but a missing BR: perl(strict). i.e. please add BuildRequires: perl(strict) Besides this, similar remarks wrt. rhel as with your other packages also apply here.
spec and src rpm updated. BR:s added and implemented remarks from the other packages.
I updated the spec file according to comments from the related bugs and uploaded new files here: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect-0.02-1.fc21.noarch.rpm
Source RPM: http://nierlein.com/fedora/2014-04-06/perl-LWP-Protocol-connect-6.06-1.fc21.src.rpm
(In reply to Sven Nierlein from comment #4) > Source RPM: > http://nierlein.com/fedora/2014-04-06/perl-LWP-Protocol-connect-6.06-1.fc21. > src.rpm Wrong BZ? (In reply to Sven Nierlein from comment #3) > http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Redirect-0.02-1. > fc21.noarch.rpm Please increment the NEVR each time you change your package. This review isn't going anywhere unless you finally do so.
ok, sorry, this is my first review. I will update the packages and do a new upload.
So what would be the correct way to continue, my idea is, that we have a correct spec file at the end of the review process. So i would increase the NEVR, update the last changelog entry (date and version) and upload new files.
new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-Redirect.spec i only changed the release number.
Missing [MUSTFIX]: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
I update the spec file and added the compat requires and more BRs according to cpanspec. New files are here: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Redirect-0.02-3.fc21.src.rpm
Closer but still no cigar: Please remove the "R: perl(Catalyst)". It's redundant to what rpm detects automatically.
Ok, thanks for your feedback, updated files are located here: http://nierlein.com/fedora/2014-07-25/perl-Catalyst-Plugin-Redirect.spec http://nierlein.com/fedora/2014-07-25/perl-Catalyst-Plugin-Redirect-0.02-4.fc22.src.rpm
Everything's OK, now. APPROVED
New Package SCM Request ======================= Package Name: perl-Catalyst-Plugin-Redirect Short Description: Catalyst::Plugin::Redirect is a Catalyst Plugin that provides redirects. Owners: sni Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
build and upload completed