Bug 1080034

Summary: Guide link on Power User Portal (Extended view) is not overriden in rhev branding
Product: Red Hat Enterprise Virtualization Manager Reporter: Pavel Novotny <pnovotny>
Component: rhevm-branding-rhevAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Pavel Novotny <pnovotny>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: awels, ecohen, scohen
Target Milestone: ---   
Target Release: 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ux
Fixed In Version: av6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 948653, 1083009    
Bug Blocks: 1090946    

Description Pavel Novotny 2014-03-24 14:46:18 UTC 
Description of problem:
Bug 948653 adds branding support for separate URL for Power User Portal (PUP) Guide via an extra parameter, however this parameter is defined only in the default oVirt branding. This results that PUP Guide URL points to ovirt.org site instead of to local /docs/ location.

Version-Release number of selected component (if applicable):
rhevm-3.4.0-0.10.beta2.el6ev (av4)
rhevm-branding-rhev-3.4.0-0.1.beta1.el6ev

How reproducible:
100%

Steps to Reproduce:
1. Log into Power User Portal (Extended view)
2. Click on the Guide link at the top
3.

Actual results:
New panel/window leads us to http://www.ovirt.org/Documentation

Expected results:
It should lead us to the local documentation, currently /docs/<locale>/html/User_Portal_Guide/index.html

Additional info:

Looking into the branding content, we see "obrand.userportal.extended_guide_url" is missing in the rhev branding profile, so value from ovirt branding is used:

# grep -r guide_url /etc/ovirt-engine/branding/00-ovirt.brand/*
/etc/ovirt-engine/branding/00-ovirt.brand/external_resources.properties:obrand.webadmin.guide_url=http://www.ovirt.org/Documentation
/etc/ovirt-engine/branding/00-ovirt.brand/external_resources.properties:obrand.userportal.guide_url=http://www.ovirt.org/Documentation
/etc/ovirt-engine/branding/00-ovirt.brand/external_resources.properties:obrand.userportal.extended_guide_url=http://www.ovirt.org/Documentation

# grep -r guide_url /etc/ovirt-engine/branding/50-rhev-1.brand/*
/etc/ovirt-engine/branding/50-rhev-1.brand/external_resources.properties:obrand.webadmin.guide_url=/docs/{0}/html/Administration_Guide/index.html
/etc/ovirt-engine/branding/50-rhev-1.brand/external_resources.properties:obrand.userportal.guide_url=/docs/{0}/html/User_Portal_Guide/index.html
Comment 1 Pavel Novotny 2014-04-01 10:14:47 UTC 
Link to the Power User Portal Guide is now defined in rhev branding (rhevm-branding-rhev-3.4.0-0.3.beta1.el6ev.noarch). 
It points to /ovirt-engine/docs/manual/en_US/html/Power_User_Portal_Guide/index.html however the target page is missing.

Cannot verify further until blocking bug 1083009 is resolved.
Comment 2 Pavel Novotny 2014-04-07 10:40:04 UTC 
Re-evaluated the issue in buid av6 (rhevm-3.4.0-0.13.beta3.el6ev.noarch) and it's resolved here, moving to verified.

Verified in:
rhevm-3.4.0-0.13.beta3.el6ev.noarch
rhevm-doc-3.4.0-2.el6eng.noarch
rhevm-branding-rhev-3.4.0-0.5.beta3.el6ev.noarch

The Guide link to Power User Portal (Extended view) now points to /docs/manual/en_US/html/User_Guide/chap-The_Extended_Tab.html (for english localization).
It's defined in RHEV branding file 'external_resources.properties':

obrand.userportal.extended_guide_url=../docs/manual/{0}/html/User_Guide/chap-The_Extended_Tab.html

Also the documentation page is valid and the content is displayed correctly.
Comment 3 Itamar Heim 2014-06-12 14:11:53 UTC 
Closing as part of 3.4.0