Bug 1080622

Summary:	VMWARE: datastore selection is incorrect if token is being used
Product:	Red Hat OpenStack	Reporter:	Stephen Gordon <sgordon>
Component:	openstack-nova	Assignee:	Matthew Booth <mbooth>
Status:	CLOSED ERRATA	QA Contact:	Ami Jeain <ajeain>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.0 (RHEL 7)	CC:	mbooth, ndipanov, sclewis, slong, vpopovic, yeylon
Target Milestone:	rc
Target Release:	5.0 (RHEL 7)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-nova-2014.1-3.el7ost	Doc Type:	Bug Fix
Doc Text:	Previously, if a VMware cluster contained a large number of datastores, the VMware driver would only consider those initially returned by vSphere when selecting a datastore for deployment. If there were more datastores than were initially returned, these were never considered, which meant that new datastores were not used. With this fix, the VMware driver now checks all datastores in a cluster. A cluster may contain any number of datastores, and they will all be considered when deploying a new instance.	Story Points:	---
Clone Of:
Clones:	1086814 (view as bug list)		Environment:
Last Closed:	2014-07-08 15:28:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1055536, 1086814

Description Stephen Gordon 2014-03-25 19:39:06 UTC

Description of problem:

If the number of datastores is greater than the maximum, the PropertyCollector returns a token value that should be used to iterate over the entire result set. The get_datastore_ref_and_name function in vm_util.py is aware of tokens but it stops on the first found datastore (line 942) instead searching for the best match over the entire set.

We should improve get_datastore_ref_and_name to:
1) clearly specify how the datastore is selected (the current pydoc is wrong)
2) select the best match by iterating the whole result set

Comment 6 errata-xmlrpc 2014-07-08 15:28:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-0853.html