Bug 1080622 - VMWARE: datastore selection is incorrect if token is being used
Summary: VMWARE: datastore selection is incorrect if token is being used
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-nova
Version: 5.0 (RHEL 7)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: 5.0 (RHEL 7)
Assignee: Matthew Booth
QA Contact: Ami Jeain
URL:
Whiteboard:
Depends On:
Blocks: 1055536 1086814
TreeView+ depends on / blocked
 
Reported: 2014-03-25 19:39 UTC by Stephen Gordon
Modified: 2019-09-09 16:55 UTC (History)
6 users (show)

Fixed In Version: openstack-nova-2014.1-3.el7ost
Doc Type: Bug Fix
Doc Text:
Previously, if a VMware cluster contained a large number of datastores, the VMware driver would only consider those initially returned by vSphere when selecting a datastore for deployment. If there were more datastores than were initially returned, these were never considered, which meant that new datastores were not used. With this fix, the VMware driver now checks all datastores in a cluster. A cluster may contain any number of datastores, and they will all be considered when deploying a new instance.
Clone Of:
: 1086814 (view as bug list)
Environment:
Last Closed: 2014-07-08 15:28:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1245564 0 None None None Never
OpenStack gerrit 54361 0 None None None Never
Red Hat Product Errata RHEA-2014:0853 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform Enhancement - Compute 2014-07-08 19:22:38 UTC

Description Stephen Gordon 2014-03-25 19:39:06 UTC
Description of problem:

If the number of datastores is greater than the maximum, the PropertyCollector returns a token value that should be used to iterate over the entire result set. The get_datastore_ref_and_name function in vm_util.py is aware of tokens but it stops on the first found datastore (line 942) instead searching for the best match over the entire set.

We should improve get_datastore_ref_and_name to:
1) clearly specify how the datastore is selected (the current pydoc is wrong)
2) select the best match by iterating the whole result set

Comment 6 errata-xmlrpc 2014-07-08 15:28:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-0853.html


Note You need to log in before you can comment on or make changes to this bug.