Bug 1080858

Summary: [notifier] /etc/rc.d/init.d/ovirt-engine-notifier contains copy&paste header
Product: Red Hat Enterprise Virtualization Manager Reporter: Sandro Bonazzola <sbonazzo>
Component: ovirt-engine-notification-serviceAssignee: Alon Bar-Lev <alonbl>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: aberezin, acathrow, alonbl, gklein, iheim, jbelka, knesenko, oourfali, Rhev-m-bugs, talayan, yeylon
Target Milestone: ---Keywords: ZStream
Target Release: 3.3.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1063860 Environment:
Last Closed: 2014-04-13 07:48:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1063860    
Bug Blocks:    

Description Sandro Bonazzola 2014-03-26 09:03:05 UTC
+++ This bug was initially created as a clone of Bug #1063860 +++

Description of problem:
# sed -n '1,7p' /etc/rc.d/init.d/ovirt-engine-notifier
#!/bin/sh
#
# Start/stop oVirt Engine
#
# chkconfig: - 65 34
# description: oVirt Engine
# pidfile: /var/run/ovirt-engine.pid


Version-Release number of selected component (if applicable):
ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:
copy&paste from ovirt-engine RC script

Expected results:
modify to its own values

Additional info:

--- Additional comment from Alon Bar-Lev on 2014-02-12 03:44:41 EST ---

Were did this come from, I do not see this on source, nor machine.

# curl http://resources.ovirt.org/releases/3.4.0-beta2/rpm/EL/6Server/noarch/ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch.rpm | rpm2cpio | cpio --extract --to-stdout ./usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv | head

#!/bin/sh
#
# Start/stop oVirt Engine
#
# chkconfig: - 65 34
# description: oVirt Engine
# pidfile: /var/run/ovirt-engine.pid

### BEGIN INIT INFO
# Provides: ovirt-engine

Do you see this in other services? can you please try to trance it?

What do you have at /usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv?

--- Additional comment from Jiri Belka on 2014-02-12 04:12:31 EST ---

# egrep "^#[ \t]*(descr|pidfile)" /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-engine:# pidfile: /var/run/ovirt-engine.pid
/etc/rc.d/init.d/ovirt-engine-dwhd:# description: oVirt Engine Dataware House
/etc/rc.d/init.d/ovirt-engine-dwhd:# pidfile: /var/run/ovirt-engine-dwhd.pid
/etc/rc.d/init.d/ovirt-engine-notifier:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-engine-notifier:# pidfile: /var/run/ovirt-engine.pid
/etc/rc.d/init.d/ovirt-guest-agent:# description: Startup/shutdown script for the oVirt agent.
/etc/rc.d/init.d/ovirt-guest-agent:# pidfile: /var/run/ovirt-guest-agent.pid
/etc/rc.d/init.d/ovirt-websocket-proxy:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-websocket-proxy:# pidfile: /var/run/ovirt-engine.pid

[root@jb-rh34 ~]# ls /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine       /etc/rc.d/init.d/ovirt-engine-notifier  /etc/rc.d/init.d/ovirt-websocket-proxy
/etc/rc.d/init.d/ovirt-engine-dwhd  /etc/rc.d/init.d/ovirt-guest-agent
[root@jb-rh34 ~]# ls /etc/rc.d/init.d/ovirt-* | xargs rpm -qf
ovirt-engine-backend-3.4.0-0.7.beta2.el6.noarch
ovirt-engine-dwh-3.4.0-0.2.master.20140205160753.el6.noarch
ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch
rhevm-guest-agent-common-1.0.8-6.el6ev.noarch
ovirt-engine-websocket-proxy-3.4.0-0.7.beta2.el6.noarch

--- Additional comment from Jiri Belka on 2014-02-12 04:14:02 EST ---

I'm still "complaining" about header, real vars are OK.

[root@jb-rh34 ~]# egrep "^(NAME|PIDFILE|PROG)" /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine:NAME="ovirt-engine"
/etc/rc.d/init.d/ovirt-engine:PROG="oVirt Engine"
/etc/rc.d/init.d/ovirt-engine:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-engine-dwhd:NAME="ovirt-engine-dwhd"
/etc/rc.d/init.d/ovirt-engine-dwhd:PROG="oVirt Engine Dataware House"
/etc/rc.d/init.d/ovirt-engine-dwhd:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-engine-notifier:NAME="ovirt-engine-notifier"
/etc/rc.d/init.d/ovirt-engine-notifier:PROG="oVirt Engine Notifier"
/etc/rc.d/init.d/ovirt-engine-notifier:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-websocket-proxy:NAME="ovirt-websocket-proxy"
/etc/rc.d/init.d/ovirt-websocket-proxy:PROG="oVirt Engine websockets proxy"
/etc/rc.d/init.d/ovirt-websocket-proxy:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"

--- Additional comment from Alon Bar-Lev on 2014-02-12 04:56:28 EST ---

ok, I thought the sed was the issue...

--- Additional comment from Itamar Heim on 2014-02-16 03:23:37 EST ---

Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

--- Additional comment from Jiri Belka on 2014-02-25 04:01:17 EST ---

ok, beta3

Comment 1 Jiri Belka 2014-03-28 08:58:31 UTC
ok, rhevm-3.3.2-0.50.el6ev.noarch

Comment 2 Kiril Nesenko 2014-04-13 07:48:40 UTC
Was released with 3.3.2