Bug 1063860 - [notifier] /etc/rc.d/init.d/ovirt-engine-notifier contains copy&paste header
Summary: [notifier] /etc/rc.d/init.d/ovirt-engine-notifier contains copy&paste header
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-notificiations
Version: 3.4
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 3.4.0
Assignee: Alon Bar-Lev
QA Contact: Jiri Belka
URL:
Whiteboard: integration
Depends On:
Blocks: 1080858
TreeView+ depends on / blocked
 
Reported: 2014-02-11 14:51 UTC by Jiri Belka
Modified: 2014-03-31 12:32 UTC (History)
8 users (show)

Fixed In Version: ovirt-3.4.0-beta3
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1080858 (view as bug list)
Environment:
Last Closed: 2014-03-31 12:32:07 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 24363 0 None None None Never
oVirt gerrit 24369 0 None None None Never
oVirt gerrit 24371 0 None None None Never

Description Jiri Belka 2014-02-11 14:51:47 UTC
Description of problem:
# sed -n '1,7p' /etc/rc.d/init.d/ovirt-engine-notifier
#!/bin/sh
#
# Start/stop oVirt Engine
#
# chkconfig: - 65 34
# description: oVirt Engine
# pidfile: /var/run/ovirt-engine.pid


Version-Release number of selected component (if applicable):
ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:
copy&paste from ovirt-engine RC script

Expected results:
modify to its own values

Additional info:

Comment 1 Alon Bar-Lev 2014-02-12 08:44:41 UTC
Were did this come from, I do not see this on source, nor machine.

# curl http://resources.ovirt.org/releases/3.4.0-beta2/rpm/EL/6Server/noarch/ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch.rpm | rpm2cpio | cpio --extract --to-stdout ./usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv | head

#!/bin/sh
#
# Start/stop oVirt Engine
#
# chkconfig: - 65 34
# description: oVirt Engine
# pidfile: /var/run/ovirt-engine.pid

### BEGIN INIT INFO
# Provides: ovirt-engine

Do you see this in other services? can you please try to trance it?

What do you have at /usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv?

Comment 2 Jiri Belka 2014-02-12 09:12:31 UTC
# egrep "^#[ \t]*(descr|pidfile)" /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-engine:# pidfile: /var/run/ovirt-engine.pid
/etc/rc.d/init.d/ovirt-engine-dwhd:# description: oVirt Engine Dataware House
/etc/rc.d/init.d/ovirt-engine-dwhd:# pidfile: /var/run/ovirt-engine-dwhd.pid
/etc/rc.d/init.d/ovirt-engine-notifier:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-engine-notifier:# pidfile: /var/run/ovirt-engine.pid
/etc/rc.d/init.d/ovirt-guest-agent:# description: Startup/shutdown script for the oVirt agent.
/etc/rc.d/init.d/ovirt-guest-agent:# pidfile: /var/run/ovirt-guest-agent.pid
/etc/rc.d/init.d/ovirt-websocket-proxy:# description: oVirt Engine
/etc/rc.d/init.d/ovirt-websocket-proxy:# pidfile: /var/run/ovirt-engine.pid

[root@jb-rh34 ~]# ls /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine       /etc/rc.d/init.d/ovirt-engine-notifier  /etc/rc.d/init.d/ovirt-websocket-proxy
/etc/rc.d/init.d/ovirt-engine-dwhd  /etc/rc.d/init.d/ovirt-guest-agent
[root@jb-rh34 ~]# ls /etc/rc.d/init.d/ovirt-* | xargs rpm -qf
ovirt-engine-backend-3.4.0-0.7.beta2.el6.noarch
ovirt-engine-dwh-3.4.0-0.2.master.20140205160753.el6.noarch
ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch
rhevm-guest-agent-common-1.0.8-6.el6ev.noarch
ovirt-engine-websocket-proxy-3.4.0-0.7.beta2.el6.noarch

Comment 3 Jiri Belka 2014-02-12 09:14:02 UTC
I'm still "complaining" about header, real vars are OK.

[root@jb-rh34 ~]# egrep "^(NAME|PIDFILE|PROG)" /etc/rc.d/init.d/ovirt-*
/etc/rc.d/init.d/ovirt-engine:NAME="ovirt-engine"
/etc/rc.d/init.d/ovirt-engine:PROG="oVirt Engine"
/etc/rc.d/init.d/ovirt-engine:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-engine-dwhd:NAME="ovirt-engine-dwhd"
/etc/rc.d/init.d/ovirt-engine-dwhd:PROG="oVirt Engine Dataware House"
/etc/rc.d/init.d/ovirt-engine-dwhd:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-engine-notifier:NAME="ovirt-engine-notifier"
/etc/rc.d/init.d/ovirt-engine-notifier:PROG="oVirt Engine Notifier"
/etc/rc.d/init.d/ovirt-engine-notifier:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"
/etc/rc.d/init.d/ovirt-websocket-proxy:NAME="ovirt-websocket-proxy"
/etc/rc.d/init.d/ovirt-websocket-proxy:PROG="oVirt Engine websockets proxy"
/etc/rc.d/init.d/ovirt-websocket-proxy:PIDFILE="${PIDFILE:-/var/run/${NAME}.pid}"

Comment 4 Alon Bar-Lev 2014-02-12 09:56:28 UTC
ok, I thought the sed was the issue...

Comment 5 Itamar Heim 2014-02-16 08:23:37 UTC
Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

Comment 6 Jiri Belka 2014-02-25 09:01:17 UTC
ok, beta3

Comment 7 Sandro Bonazzola 2014-03-31 12:32:07 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released


Note You need to log in before you can comment on or make changes to this bug.