Bug 1081016

REVIEW: http://review.gluster.org/7348 (glusterfs.spec.in: glusted requires e2fsprogs and xfsprogs) posted (#1) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

REVIEW: http://review.gluster.org/7348 (glusterfs.spec.in: glusterd requires e2fsprogs and xfsprogs) posted (#2) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Patch was abandoned, see comments in the review for details.

Should we backport http://review.gluster.org/7360 instead?

I have http://review.gluster.org/#/c/7361/ which fixes a couple other things too, e.g. not repeatedly running the tool to get the inode size, which never changes.

Moving to glusterfs-3.5.2 because there is no patch in the master branch yet.

http://review.gluster.org/7361 has been abandoned.

The related mainline bug 1081013 was used to include http://review.gluster.org/8134 .

REVIEW: http://review.gluster.org/8489 (dict: add dict_set_dynstr_with_alloc) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

REVIEW: http://review.gluster.org/8490 (glusterd: call runner_end even if runner_start fails) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

REVIEW: http://review.gluster.org/8491 (xlators/mgmt: don't allow glusterd fork bomb (cache the brick inode size)) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

COMMIT: http://review.gluster.org/8489 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 2dfe3715b56a90d5b7df914c7b67d308b0b45b67
Author: Niels de Vos <ndevos>
Date:   Thu Aug 14 17:24:12 2014 +0200

    dict: add dict_set_dynstr_with_alloc
    
    There is an overwhelming no. of instances of the following pattern in
    glusterd module.
    
        ...
    
        char *dynstr = gf_strdup (str);
        if (!dynstr)
           goto err;
        ret = dict_set_dynstr (dict, key, dynstr);
        if (ret)
           goto err;
    
        ...
    
    With this changes it would look as below,
    
       ret = dict_set_dynstr_with_alloc (dict, key, str);
       if (ret)
           goto err;
    
    Cherry picked from commit a9d4d369efc978511e3cb69e5643945710cc9416:
    > Change-Id: I6a47b1cbab4834badadc48c56d0b5c8c06c6dd4d
    > Signed-off-by: Krishnan Parthasarathi <kparthas>
    > Reviewed-on: http://review.gluster.org/7379
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Backport notes:
      Included this change to accommodate additional backports.
    
    BUG: 1081016
    Change-Id: I6a47b1cbab4834badadc48c56d0b5c8c06c6dd4d
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8489
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

COMMIT: http://review.gluster.org/8490 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit b9a52cc273cafe26b856331fcd9a804e876710a8
Author: Niels de Vos <ndevos>
Date:   Fri Aug 15 09:45:28 2014 +0200

    glusterd: call runner_end even if runner_start fails
    
    Cherry picked from commit aa199093fdf37dcd87a73cea83f9b9164d5800c5:
    > Change-Id: I5eca01a131307ba3be2aed4922eea73025ff284c
    > BUG: 1081013
    > Signed-off-by: Jeff Darcy <jdarcy>
    > Reviewed-on: http://review.gluster.org/7360
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    > Reviewed-by: Krishnan Parthasarathi <kparthas>
    > Reviewed-by: Anand Avati <avati>
    
    Change-Id: I5eca01a131307ba3be2aed4922eea73025ff284c
    BUG: 1081016
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8490
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

COMMIT: http://review.gluster.org/8491 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit b71d501392ae10de4424c325ff37afcf3bd83d32
Author: Niels de Vos <ndevos>
Date:   Fri Aug 15 09:47:42 2014 +0200

    xlators/mgmt: don't allow glusterd fork bomb (cache the brick inode size)
    
    Was don't leave zombies if required programs aren't installed
    
    Also, the existing if (strcmp (foo, bar) == 0) antipattern leaves me
    underwhelmed -- table driven is better;
    
    I like fully qualified paths to system tools too.
    
    File systems aren't going to change their inode size. Rather than
    fork-and-exec a tool repeatedly, hang on to the answer for subsequent
    use. Even if there are hundreds of volumes the size of a dict to keep
    this in memory is small.
    
    Cherry picked from commit f20d0ef8ad7d2f65a9234fc11101830873a9f6ab:
    > Change-Id: I704a8b1215446488b6e9e051a3e031af21b37adb
    > BUG: 1081013
    > Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    > Reviewed-on: http://review.gluster.org/8134
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Krishnan Parthasarathi <kparthas>
    > Tested-by: Krishnan Parthasarathi <kparthas>
    
    Change-Id: I704a8b1215446488b6e9e051a3e031af21b37adb
    BUG: 1081016
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8491
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

REVIEW: http://review.gluster.org/8663 (glusterd: fix compile warning) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

COMMIT: http://review.gluster.org/8663 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 6ad6661a2d49b444e18859391ba1bf8d71c28a39
Author: Niels de Vos <ndevos>
Date:   Tue Sep 9 10:29:08 2014 +0200

    glusterd: fix compile warning
    
    The following warning has been moved to an error and prevents the smoke tests
    in Jenkins to succeed.
    
      cc1: warnings being treated as errors
      /d/var_lib_jenkins_jobs/smoke/workspace/xlators/mgmt/glusterd/src/glusterd-utils.c: In function ‘glusterd_add_inode_size_to_dict’:
      /d/var_lib_jenkins_jobs/smoke/workspace/xlators/mgmt/glusterd/src/glusterd-utils.c:5038: error: unused variable ‘inode_size’
    
    The warning was introduced with http://review.gluster.org/8491.
    
    Change-Id: I0c824aaf6df70dea35364af6fa72f34eea8c9829
    BUG: 1081016
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8663
    Reviewed-by: Santosh Pradhan <spradhan>
    Tested-by: Gluster Build System <jenkins.com>

The first (and last?) Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-October/018990.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

The second Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions have been made available on [2] to make testing easier.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019359.html
[2] http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.3beta2/

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.3, please reopen this bug report.

glusterfs-3.5.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/announce/2014-November/000042.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/