Bug 1083027

Summary: Blank value can be set for system-limit while creating activation-key
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: WebUIAssignee: Tom McKay <tomckay>
WebUI sub component: Katello QA Contact: Katello QA List <katello-qa-list>
Status: CLOSED DUPLICATE Docs Contact:
Severity: low    
Priority: unspecified CC: bbuckingham, sghai, tomckay
Version: 6.0.3Keywords: Triaged
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-25 18:34:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
activation key 'test' with blank system limit none

Description Sachin Ghai 2014-04-01 10:54:27 UTC
Created attachment 881287 [details]
activation key 'test' with blank system limit

Description of problem:
I was trying to set some value for system limit while creating activation key. Then I just passed blank value under the limit textbox and it was accepted by UI.


Version-Release number of selected component (if applicable):
snap5 compose4* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.7-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.7-1.el6_5.noarch
* candlepin-tomcat6-0.9.7-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.5.0.16-1.el6sat.noarch
* foreman-postgresql-1.5.0.16-1.el6sat.noarch
* foreman-proxy-1.5.4-1.el6sat.noarch
* foreman-release-1.5.0-0.develop.201403311342git846433a.el6.noarch
* foreman-selinux-1.5.0-0.develop.el6sat.noarch
* katello-1.5.0-19.el6sat.noarch
* katello-apache-1.0-1.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.5-1.el6sat.noarch
* katello-installer-0.0.32-1.el6sat.noarch
* katello-repos-1.5.1-1.git.14.0868bd1.el6.noarch
* openldap-2.4.23-32.el6_4.1.x86_64
* pulp-katello-plugins-0.2-1.el6sat.noarch
* pulp-nodes-common-2.3.1-0.4.beta.el6sat.noarch
* pulp-nodes-parent-2.3.1-0.4.beta.el6sat.noarch
* pulp-puppet-plugins-2.3.1-0.4.beta.el6sat.noarch
* pulp-rpm-plugins-2.3.1-0.4.beta.el6sat.noarch
* pulp-selinux-2.3.1-0.4.beta.el6sat.noarch
* pulp-server-2.3.1-0.4.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-2.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.0.8-1.el6sat.noarch
* rubygem-hammer_cli-0.1.0-5.el6sat.noarch
* rubygem-hammer_cli_foreman-0.1.0-6.el6sat.noarch
* rubygem-hammer_cli_foreman_tasks-0.0.2-2.el6sat.noarch
* rubygem-hammer_cli_katello-0.0.3-12.el6sat.noarch


How reproducible:
always

Steps to Reproduce:
1. create activation key
2. set the system limit to with blank values" "
3. edit with space bar and save it 

Actual results:
activation key can be created with unknown/blank value

Expected results:
user shouldn't be allowed to create activation key with unknown/blank system limit. A validation error should be raised.


Additional info:

Comment 1 RHEL Program Management 2014-04-01 10:56:14 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Tom McKay 2014-05-21 18:39:41 UTC
This was intended behavior to be a way to indicate "unlimited". Is this an automated test or did you find it confusing?

Comment 4 Sachin Ghai 2014-05-22 05:08:34 UTC
@Tom, I've validated activation-key related stuff with old two-tupane UI.. And If I recall correctly, there we were using '-1' value to set the limit to 'unlimited'. And for blank value, a validation error was raised.

So I was expecting same validation error here with new UI. But looks like we can no more use -1 for setting the limit to unlimited. If setting blank value is a expected behaviour to indicate "unlimited" then I'm fine with it.

Comment 5 Tom McKay 2014-06-25 18:34:22 UTC

*** This bug has been marked as a duplicate of bug 1097054 ***