Bug 1097054 - Text should not be accepted as a limit for activation keys and host collections
Summary: Text should not be accepted as a limit for activation keys and host collections
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Walden Raines
QA Contact: sthirugn@redhat.com
URL: http://projects.theforeman.org/issues...
Whiteboard:
: 1083027 1105443 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-13 05:37 UTC by Sachin Ghai
Modified: 2019-09-26 18:15 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:20:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
rotatating spinner with text working (45.11 KB, image/png)
2014-05-13 05:37 UTC, Sachin Ghai
no flags Details
firebug raises error while setting the limit with some str (104.50 KB, image/png)
2014-05-16 07:20 UTC, Sachin Ghai
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6300 0 None None None 2016-04-22 16:33:09 UTC
Red Hat Bugzilla 1122715 0 unspecified CLOSED hammer activation-key allows -1 and text inputs for max-content-hosts 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1122716 0 unspecified CLOSED hammer host-collection fails to set specified host collection limit 2021-02-22 00:41:40 UTC

Internal Links: 1122715 1122716

Description Sachin Ghai 2014-05-13 05:37:19 UTC
Created attachment 894991 [details]
rotatating spinner with text working

Description of problem:
I was trying to update the system limit of selected activation key and trying to validate that limit with some special characters and strings. But when I entered a string and clicked on save, a spinner starts rotating with a text 'working'

And when I navigate away, the limit was set to same as it was originally. 

Version-Release number of selected component (if applicable):
Satellite 6 Beta Snap 4

Satellite-6.0.3-RHEL-6-20140508.1


How reproducible:
always

Steps to Reproduce:
1. create a activation key with system limit to 1
2. update the system limit with some string
3.

Actual results:
updating the system limit with some string gives a spinner rotating with a text 'working'

Expected results:
user should get proper validation error.

Additional info:

Comment 1 RHEL Program Management 2014-05-13 05:54:46 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Brad Buckingham 2014-05-15 17:44:27 UTC
The behavior worked ok for me in Chrome, but I did see the issue described with Firefox.

Comment 4 Sachin Ghai 2014-05-16 07:20:52 UTC
Created attachment 896218 [details]
firebug raises error while setting the limit with some str

Comment 5 Christine Fouant 2014-06-19 19:58:38 UTC
Created redmine issue http://projects.theforeman.org/issues/6300 from this bug

Comment 6 Walden Raines 2014-06-25 18:21:11 UTC
This issue should fix both activation keys and system groups for both client and server.

Comment 7 Tom McKay 2014-06-25 18:34:22 UTC
*** Bug 1083027 has been marked as a duplicate of this bug. ***

Comment 8 Walden Raines 2014-06-27 16:13:32 UTC
PR: https://github.com/Katello/katello/pull/4360

Comment 9 Walden Raines 2014-07-02 15:51:31 UTC
*** Bug 1105443 has been marked as a duplicate of this bug. ***

Comment 10 Bryan Kearney 2014-07-08 20:01:54 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/6300 has been closed
-------------
Walden Raines
https://github.com/Katello/katello/pull/4360
-------------
Walden Raines
Applied in changeset commit:katello|607f4e7fdeefa10091b24a8a06fd2a45939c6038.

Comment 12 sthirugn@redhat.com 2014-07-23 20:44:55 UTC
Good work by Walden Raines here:

Verified. Now I am not able to enter text or -1 or any special characters for Activation key limit or Content host limit.

Version Tested:
* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.19-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.19-1.el6_5.noarch
* candlepin-tomcat6-0.9.19-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.6.0.29-1.el6sat.noarch
* foreman-compute-1.6.0.29-1.el6sat.noarch
* foreman-gce-1.6.0.29-1.el6sat.noarch
* foreman-libvirt-1.6.0.29-1.el6sat.noarch
* foreman-ovirt-1.6.0.29-1.el6sat.noarch
* foreman-postgresql-1.6.0.29-1.el6sat.noarch
* foreman-proxy-1.6.0.21-1.el6sat.noarch
* foreman-selinux-1.6.0-8.el6sat.noarch
* foreman-vmware-1.6.0.29-1.el6sat.noarch
* katello-1.5.0-27.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.56-1.el6sat.noarch
* openldap-2.4.23-32.el6_4.1.x86_64
* pulp-katello-0.3-3.el6sat.noarch
* pulp-nodes-common-2.4.0-0.23.beta.el6sat.noarch
* pulp-nodes-parent-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-tools-2.4.0-0.23.beta.el6sat.noarch
* pulp-rpm-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-selinux-2.4.0-0.23.beta.el6sat.noarch
* pulp-server-2.4.0-0.23.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch

Comment 13 sthirugn@redhat.com 2014-07-23 20:58:50 UTC
My above comment is with respect to UI.  CLI still fails which will be documented in a separate bug.

Comment 14 sthirugn@redhat.com 2014-07-24 13:48:45 UTC
Two new related hammer bugs are created now:
https://bugzilla.redhat.com/show_bug.cgi?id=1122715
https://bugzilla.redhat.com/show_bug.cgi?id=1122716

Comment 16 Bryan Kearney 2014-09-11 12:20:22 UTC
This was delivered with Satellite 6.0 which was released on 10 September 2014.


Note You need to log in before you can comment on or make changes to this bug.