Bug 1083839

Summary:	Review Request: js-crc32 - JavaScript library reimplementing CRC
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	Package Review	Assignee:	Tom Hughes <tom>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, tom
Target Milestone:	---	Flags:	tom: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-14 11:32:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1083836

Description Zbigniew Jędrzejewski-Szmek 2014-04-03 04:52:13 UTC

Spec: http://in.waw.pl/~zbyszek/fedora/js-crc32.spec
SRPM: http://in.waw.pl/~zbyszek/fedora/js-crc32-0.2.2-1.fc21.src.rpm
Description: JavaScript library reimplementing CRC
Fedora Account System Username: zbyszek

Comment 1 Tom Hughes 2014-04-05 15:06:15 UTC

The %check section seems to be wrong - this module doesn't use buster but has some tests which can be run with the runTests.sh script in the test directory.

Comment 2 Tom Hughes 2014-04-05 15:09:05 UTC

Also per https://fedoraproject.org/wiki/Packaging:JavaScript#Node.js_Modules_that_contain_browser.2Fpure-JS_components this should have a nodejs-crc32 subpackage that packages the package.json etc for node.

Comment 3 Tom Hughes 2014-04-05 15:11:32 UTC

Oh I see you filed that as a separate package in BZ#1083836 but per the guidelines I think that is wrong and it should be one SRPM that generates both subpackages. Personally I'd go for nodejs-crc32 as the SRPM but I'm open to discussion on that.

Comment 4 Zbigniew Jędrzejewski-Szmek 2014-08-15 03:11:51 UTC

Unfortunately I don't seem to have enough bandwidth to take care of this properly and to learn nodejs properly. I'm abandoning this attempt at packaging. Sorry for the wasted work on review.

I'll leave this open, if someone wants to take over, please go ahead.