Bug 1083839 - Review Request: js-crc32 - JavaScript library reimplementing CRC
Summary: Review Request: js-crc32 - JavaScript library reimplementing CRC
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On:
Blocks: 1083836
TreeView+ depends on / blocked
 
Reported: 2014-04-03 04:52 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2019-09-14 11:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-09-14 11:32:11 UTC
Type: ---
Embargoed:
tom: fedora-review?

Attachments (Terms of Use)

Description Zbigniew Jędrzejewski-Szmek 2014-04-03 04:52:13 UTC 
Spec: http://in.waw.pl/~zbyszek/fedora/js-crc32.spec
SRPM: http://in.waw.pl/~zbyszek/fedora/js-crc32-0.2.2-1.fc21.src.rpm
Description: JavaScript library reimplementing CRC
Fedora Account System Username: zbyszek
Comment 1 Tom Hughes 2014-04-05 15:06:15 UTC 
The %check section seems to be wrong - this module doesn't use buster but has some tests which can be run with the runTests.sh script in the test directory.
Comment 2 Tom Hughes 2014-04-05 15:09:05 UTC 
Also per https://fedoraproject.org/wiki/Packaging:JavaScript#Node.js_Modules_that_contain_browser.2Fpure-JS_components this should have a nodejs-crc32 subpackage that packages the package.json etc for node.
Comment 3 Tom Hughes 2014-04-05 15:11:32 UTC 
Oh I see you filed that as a separate package in BZ#1083836 but per the guidelines I think that is wrong and it should be one SRPM that generates both subpackages. Personally I'd go for nodejs-crc32 as the SRPM but I'm open to discussion on that.
Comment 4 Zbigniew Jędrzejewski-Szmek 2014-08-15 03:11:51 UTC 
Unfortunately I don't seem to have enough bandwidth to take care of this properly and to learn nodejs properly. I'm abandoning this attempt at packaging. Sorry for the wasted work on review.

I'll leave this open, if someone wants to take over, please go ahead.
Note You need to log in before you can comment on or make changes to this bug.