Bug 1085028

Summary: group name links in access policy tab do not URL-encode group names
Product: [Retired] Beaker Reporter: xjia <xjia>
Component: web UIAssignee: matt jia <mjia>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: medium Docs Contact: matt jia <mjia>
Priority: medium    
Version: developCC: aigao, asaha, dcallagh, mjia, rmancy, xtian
Target Milestone: 0.16.2   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-28 23:00:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1073767    
Bug Blocks:    

Comment 2 xjia 2014-04-07 15:40:49 UTC
Error log in beaker-errors.log: 
Apr  7 14:39:37 beaker-devel beaker-server[31853]: bkr.server.group ERROR Group name jia?123 is not a valid group name
Apr  7 14:39:37 beaker-devel beaker-server[31853]:  Traceback (most recent call last):
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib/python2.6/site-packages/bkr/server/group.py", line 250, in edit
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      group = Group.by_name(group_name)
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib/python2.6/site-packages/bkr/server/model/identity.py", line 380, in by_name
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      return cls.query.filter_by(group_name=name).one()
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib64/python2.6/site-packages/sqlalchemy/orm/query.py", line 1684, in one
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      raise orm_exc.NoResultFound("No row was found for one()")

Comment 3 Dan Callaghan 2014-04-07 22:40:05 UTC
Well spotted!

We are intentionally using group_name because group_id is not available to the widget code in this case. The group name just needs to be correctly encoded.

Comment 4 matt jia 2014-04-08 01:44:34 UTC
On gerrit:

http://gerrit.beaker-project.org/#/c/3001/

Cheers, Matt Jia

Comment 7 Dan Callaghan 2014-04-28 23:00:34 UTC
Beaker 0.16.2 has been released.