Bug 1085028 - group name links in access policy tab do not URL-encode group names
Summary: group name links in access policy tab do not URL-encode group names
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: develop
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 0.16.2
Assignee: matt jia
QA Contact: tools-bugs
matt jia
URL:
Whiteboard:
Depends On: 1073767
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-07 14:54 UTC by xjia
Modified: 2018-02-06 00:41 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-28 23:00:34 UTC
Embargoed:

Attachments (Terms of Use)

Comment 2 xjia 2014-04-07 15:40:49 UTC 
Error log in beaker-errors.log: 
Apr  7 14:39:37 beaker-devel beaker-server[31853]: bkr.server.group ERROR Group name jia?123 is not a valid group name
Apr  7 14:39:37 beaker-devel beaker-server[31853]:  Traceback (most recent call last):
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib/python2.6/site-packages/bkr/server/group.py", line 250, in edit
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      group = Group.by_name(group_name)
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib/python2.6/site-packages/bkr/server/model/identity.py", line 380, in by_name
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      return cls.query.filter_by(group_name=name).one()
Apr  7 14:39:37 beaker-devel beaker-server[31853]:    File "/usr/lib64/python2.6/site-packages/sqlalchemy/orm/query.py", line 1684, in one
Apr  7 14:39:37 beaker-devel beaker-server[31853]:      raise orm_exc.NoResultFound("No row was found for one()")
Comment 3 Dan Callaghan 2014-04-07 22:40:05 UTC 
Well spotted!

We are intentionally using group_name because group_id is not available to the widget code in this case. The group name just needs to be correctly encoded.
Comment 4 matt jia 2014-04-08 01:44:34 UTC 
On gerrit:

http://gerrit.beaker-project.org/#/c/3001/

Cheers, Matt Jia
Comment 7 Dan Callaghan 2014-04-28 23:00:34 UTC 
Beaker 0.16.2 has been released.
Note You need to log in before you can comment on or make changes to this bug.