Bug 1085569
| Summary: | Change _word suffix in Rule Engine params | ||
|---|---|---|---|
| Product: | [Community] Bugzilla | Reporter: | Simon Green <sgreen> |
| Component: | Internal Tools | Assignee: | Matt Tyson 🤬 <mtyson> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Simon Green <sgreen> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.4 | CC: | ebaak, jmcdonal, mtyson, rjoost |
| Target Milestone: | 4.4 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 4.4.4021 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-07 00:30:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1017534, 1080286 | ||
| Bug Blocks: | 1119092 | ||
This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug. -- simon |
Description of problem: In the rule engine, for multiple values fields, we use the _word suffix in the CGI params for the action word ('set', 'remove', 'add') or the matching criteria ('is any of', 'is all of', 'is not any of'). For example p2_keywords_word = 'is any of' p2_keywords = ['CodeChange', 'Regression'] This worded well because there were no fields that ended in _word. Now that we offer custom fields as actions and they can end in _word. This needs to change. Version-Release number of selected component (if applicable): master How reproducible: always Steps to Reproduce: 1. Create a multi value custom field that ends with _word Additional info: There are two possibilities on what to change. One is changing '_word' to '!word'. The other is to put the '_word' part before the field name. I'm thinking the second option would be best. For consistency, I would change the flag requestee and ignore to appear before the flag name too (e.g. change 'p3_flag_pm_ack_ignore' to 'p3_flag_ignore_pm_ack')