Bug 1085569 - Change _word suffix in Rule Engine params
Summary: Change _word suffix in Rule Engine params
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: Internal Tools
Version: 4.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 4.4
Assignee: Matt Tyson 🤬
QA Contact: Simon Green
URL:
Whiteboard:
Depends On: bre, bugbot2 1080286
Blocks: 1119092
TreeView+ depends on / blocked
 
Reported: 2014-04-08 23:46 UTC by Simon Green
Modified: 2018-12-09 06:29 UTC (History)
4 users (show)

Fixed In Version: 4.4.4021
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-07 00:30:25 UTC
Embargoed:


Attachments (Terms of Use)

Description Simon Green 2014-04-08 23:46:14 UTC
Description of problem:
In the rule engine, for multiple values fields, we use the _word suffix in the CGI params for the action word ('set', 'remove', 'add') or the matching criteria ('is any of', 'is all of', 'is not any of'). For example

p2_keywords_word = 'is any of'
p2_keywords = ['CodeChange', 'Regression']

This worded well because there were no fields that ended in _word. Now that we offer custom fields as actions and they can end in _word. This needs to change.

Version-Release number of selected component (if applicable):
master

How reproducible:
always

Steps to Reproduce:
1. Create a multi value custom field that ends with _word

Additional info:
There are two possibilities on what to change. One is changing '_word' to '!word'. The other is to put the '_word' part before the field name. I'm thinking the second option would be best.

For consistency, I would change the flag requestee and ignore to appear before the flag name too (e.g. change 'p3_flag_pm_ack_ignore' to 'p3_flag_ignore_pm_ack')

Comment 3 Simon Green 2014-07-07 00:30:25 UTC
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.

  -- simon


Note You need to log in before you can comment on or make changes to this bug.