Bug 1085671
| Summary: | [barrier] reconfiguration of barrier time out does not work | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Atin Mukherjee <amukherj> | |
| Component: | core | Assignee: | Atin Mukherjee <amukherj> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | SATHEESARAN <sasundar> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | bugs, gluster-bugs, sasundar | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.6.0beta1 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1100567 (view as bug list) | Environment: | ||
| Last Closed: | 2014-11-11 08:29:41 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1100567 | |||
|
Description
Atin Mukherjee
2014-04-09 06:12:11 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#1) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#2) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#3) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#4) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#5) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#6) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#7) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#8) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#9) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#10) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#11) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#12) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/7428 committed in master by Vijay Bellur (vbellur) ------ commit b6cc23204f1941184cb08ec3d84beecd2d06fd91 Author: Atin Mukherjee <amukherj> Date: Wed Apr 9 11:53:33 2014 +0530 glusterfs-server : barrier timeout tuning fix Problem : Reconfiguration of barrier timeout through gluster volume set shows a success but it never changes the default timeout value which is 120 seconds. After digging into the code deeper, it was found that timeout is never modified in reconfigure() as the first check i.e. whether barrier is already enabled or disabled always fails since barrier option is not modified in this request. Fix : Introduced notify() in barrier translator which will take care of the rpc request to enable/disable barrier. reconfigure() will simply set barrier enable/disable and timeout options blindly without any validation. Please note this patch only contains the changes in barrier translator however from complete code flow perspective the caller in the glusterfsd mgmt should call notify instead of reconfigure to fix this problem. Change-Id: I1371b294935f6054da7c1dc6a9a19f1d861e60fb BUG: 1085671 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/7428 Reviewed-by: Varun Shastry <vshastry> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users |