Bug 1085671 - [barrier] reconfiguration of barrier time out does not work
Summary: [barrier] reconfiguration of barrier time out does not work
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1100567
TreeView+ depends on / blocked
 
Reported: 2014-04-09 06:12 UTC by Atin Mukherjee
Modified: 2014-11-11 08:29 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1100567 (view as bug list)
Environment:
Last Closed: 2014-11-11 08:29:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2014-04-09 06:12:11 UTC
Description of problem:

When seting barrier timeout to a x seconds, the timeout event still relies on the default timeout value.
Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Set the barrier timeout to 18000 seconds. 
2. Take a statedump of the volume and verify the timeout


Actual results:
timeout still reflects a default value.

Expected results:
timeout should be reconfigured.

Additional info:

Comment 1 Anand Avati 2014-04-09 06:32:24 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2014-04-09 07:11:40 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2014-04-09 08:47:58 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2014-04-09 09:17:34 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2014-04-09 09:19:08 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2014-04-10 04:58:55 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#6) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2014-04-10 08:59:59 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#7) for review on master by Atin Mukherjee (amukherj)

Comment 8 Anand Avati 2014-04-10 09:08:50 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#8) for review on master by Atin Mukherjee (amukherj)

Comment 9 Anand Avati 2014-04-10 10:00:11 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#9) for review on master by Atin Mukherjee (amukherj)

Comment 10 Anand Avati 2014-04-11 06:19:21 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#10) for review on master by Atin Mukherjee (amukherj)

Comment 11 Anand Avati 2014-04-15 06:33:03 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#11) for review on master by Atin Mukherjee (amukherj)

Comment 12 Anand Avati 2014-04-15 06:55:27 UTC
REVIEW: http://review.gluster.org/7428 (glusterfs-server : barrier timeout tuning fix) posted (#12) for review on master by Atin Mukherjee (amukherj)

Comment 13 Anand Avati 2014-04-22 20:03:18 UTC
COMMIT: http://review.gluster.org/7428 committed in master by Vijay Bellur (vbellur) 
------
commit b6cc23204f1941184cb08ec3d84beecd2d06fd91
Author: Atin Mukherjee <amukherj>
Date:   Wed Apr 9 11:53:33 2014 +0530

    glusterfs-server : barrier timeout tuning fix
    
    Problem : Reconfiguration of barrier timeout through gluster volume set shows a
    success but it never changes the default timeout value which is 120 seconds.
    After digging into the code deeper, it was found that timeout is never modified
    in reconfigure() as the first check i.e. whether barrier is already enabled or
    disabled always fails since barrier option is not modified in this request.
    
    Fix : Introduced notify() in barrier translator which will take care of the rpc
    request to enable/disable barrier. reconfigure() will simply set barrier
    enable/disable and timeout options blindly without any validation.
    
    Please note this patch only contains the changes in barrier translator however
    from complete code flow perspective the caller in the glusterfsd mgmt should
    call notify instead of reconfigure to fix this problem.
    
    Change-Id: I1371b294935f6054da7c1dc6a9a19f1d861e60fb
    BUG: 1085671
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/7428
    Reviewed-by: Varun Shastry <vshastry>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 14 Niels de Vos 2014-09-22 12:37:46 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 15 Niels de Vos 2014-11-11 08:29:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.