Bug 1086281

Summary: refactor upload command usage
Product: [Retired] Pulp Reporter: Michael Hrivnak <mhrivnak>
Component: z_otherAssignee: pulp-bugs
Status: CLOSED UPSTREAM QA Contact: pulp-qe-list
Severity: low Docs Contact:
Priority: medium    
Version: 2.4 BetaCC: skarmark
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-28 22:04:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Hrivnak 2014-04-10 14:11:17 UTC
The upload command has been slightly reworked, so it will create a default "upload manager" for itself. This was because each set of extensions had exactly the same 7 lines of code to create a boiler-plate manager. It had clearly been copy-pasted.

This work should
- remove calls to the command's "initialize()" method, which no longer has any effect
- remove the boiler-plate "_upload_manager()" functions in the extensions that create an upload manager, letting the base class do it for you

Example that should be removed: https://github.com/pulp/pulp_rpm/blob/4a2403a5d840f36fd78d5c9a2d482c813523227a/extensions_admin/pulp_rpm/extensions/admin/rpm_repo/pulp_cli.py#L115

Comment 1 Brian Bouterse 2015-02-28 22:04:44 UTC
Moved to https://pulp.plan.io/issues/414