Bug 1086281 - refactor upload command usage
Summary: refactor upload command usage
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: 2.4 Beta
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: pulp-bugs
QA Contact: pulp-qe-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-10 14:11 UTC by Michael Hrivnak
Modified: 2015-02-28 22:04 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-28 22:04:44 UTC


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Pulp Redmine 414 0 None None None Never

Description Michael Hrivnak 2014-04-10 14:11:17 UTC
The upload command has been slightly reworked, so it will create a default "upload manager" for itself. This was because each set of extensions had exactly the same 7 lines of code to create a boiler-plate manager. It had clearly been copy-pasted.

This work should
- remove calls to the command's "initialize()" method, which no longer has any effect
- remove the boiler-plate "_upload_manager()" functions in the extensions that create an upload manager, letting the base class do it for you

Example that should be removed: https://github.com/pulp/pulp_rpm/blob/4a2403a5d840f36fd78d5c9a2d482c813523227a/extensions_admin/pulp_rpm/extensions/admin/rpm_repo/pulp_cli.py#L115

Comment 1 Brian Bouterse 2015-02-28 22:04:44 UTC
Moved to https://pulp.plan.io/issues/414


Note You need to log in before you can comment on or make changes to this bug.