Bug 1086447 (kf5-filesystem, kf5-rpmmacros)
| Summary: | Review Request: kf5 - Filesystem ownership and RPM macros for KF5 packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, jeischma, jgrulich, kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-22 14:23:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148 | ||
|
Description
Daniel Vrátil
2014-04-10 23:13:22 UTC
1. %define framework filesystem
Use %global.
2. cp %{_sourcedir}/macros.kf5 %{buildroot}%{_rpmconfigdir}/macros.d
I prefer using install -pm644 as it can notly set the permission but also can preserve the timestamp.
Are you sure it can be built successfully? I first saw the SPEC then came up with this question, followed by mock output:
Processing files: kf5-filesystem-4.98.0-2.noarch
RPM build errors:
error: File must begin with "/": %{_kf5_includedir}
error: File must begin with "/": %{_kf5_plugindir}
error: File must begin with "/": %{_kf5_datadir}
File must begin with "/": %{_kf5_includedir}
File must begin with "/": %{_kf5_plugindir}
File must begin with "/": %{_kf5_datadir}
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem-4.98.0-3.src.rpm Replaced %define by %global and cp by install, fixed build (I had the macros.kf5 file already installed, so it didn't fail for me, sorry for that) PACKAGE APPROVED. It was decided on last KDE SIG meeting that we want to split the package to kf5-filesystem and kf5-rpmmacros (and eventually add kf5-settings if we decide we need it in future), so I renamed the base package to "kf5" and updated the request accordingly. Nothing much has changed, but I'd like to ask you for a new review anyway. Thanks and sorry for the trouble :-) Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm Should be kf5-rpm-macros. Isn't it? Good point. I just updated the specfile, didn't bump Release. Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm Add missing dots at the end of the %description. Others are perfect. New Package SCM Request ======================= Package Name: kf5 Short Description: Filesystem ownership and RPM macros for KDE Frameworks 5 packages Owners: dvratil Branches: InitialCC: rdieter jgrulich ltinkl kkofler Git done (by process-git-requests). Package pushed and built in Koji for rawhide/F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6764931 Package Change Request ====================== Package Name: kf5 New Branches: f20 Owners: dvratil rdieter jgrulich ltinkl kkofler Git done (by process-git-requests). |