Bug 1086448 (kf5-attica)

Summary: Review Request: kf5-attica - KDE Frameworks Tier 1 Addon with implementation of the Open Collaboration Services API
Product: [Fedora] Fedora Reporter: Daniel Vrátil <dvratil>
Component: Package ReviewAssignee: Jan Grulich <jgrulich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jeischma, jgrulich, kevin, package-review
Target Milestone: ---Flags: jgrulich: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-19 09:05:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 656997, 1086148    

Description Daniel Vrátil 2014-04-10 23:19:17 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-1.fc20.src.rpm
Description: Attica is a Tier 1 KDE Framework that implements the Open Collaboration Services API version 1.4.
Fedora Account System Username: dvratil

This is the very first of Tier 1 Frameworks. I'll update all the other Frameworks specfiles based on this review, so that we can do it all in as few rounds as possible.
Comment 1 Jan Grulich 2014-04-22 14:45:56 UTC 
1) Obsoletes and Provides should be versioned, see [1]
2) Rpmlint says that summary is too long, so it should be probably shorter

[1] - https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Comment 2 Daniel Vrátil 2014-05-05 09:21:44 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-2.fc20.src.rpm

- shortened summary a bit
- removed Provides, Obsoletes - they were introduced in kde-frameworks Copr repo, but are not needed in Fedora
Comment 3 Jan Grulich 2014-05-05 09:32:13 UTC 
Approved, now it looks okay to me.
Comment 4 Daniel Vrátil 2014-05-05 12:58:06 UTC 
New Package SCM Request
=======================
Package Name: kf5-attica
Short Description: KDE Frameworks Tier 1 Addon with Open Collaboration Services API
Owners: dvratil ltinkl rdieter kkofler jgrulich
Branches:
InitialCC:
Comment 5 Gwyn Ciesla 2014-05-05 13:10:31 UTC 
Git done (by process-git-requests).
Comment 6 Daniel Vrátil 2014-09-25 08:38:25 UTC 
Package Change Request
=======================
Package Name: 
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 7 Daniel Vrátil 2014-09-25 08:44:42 UTC 
Package Change Request
=======================
Package Name: kf5-attica
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 8 Gwyn Ciesla 2014-09-25 12:12:59 UTC 
Git done (by process-git-requests).