Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-1.fc20.src.rpm Description: Attica is a Tier 1 KDE Framework that implements the Open Collaboration Services API version 1.4. Fedora Account System Username: dvratil This is the very first of Tier 1 Frameworks. I'll update all the other Frameworks specfiles based on this review, so that we can do it all in as few rounds as possible.
1) Obsoletes and Provides should be versioned, see [1] 2) Rpmlint says that summary is too long, so it should be probably shorter [1] - https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-2.fc20.src.rpm - shortened summary a bit - removed Provides, Obsoletes - they were introduced in kde-frameworks Copr repo, but are not needed in Fedora
Approved, now it looks okay to me.
New Package SCM Request ======================= Package Name: kf5-attica Short Description: KDE Frameworks Tier 1 Addon with Open Collaboration Services API Owners: dvratil ltinkl rdieter kkofler jgrulich Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than
Package Change Request ======================= Package Name: kf5-attica New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than