Bug 1086664
| Summary: | Review Request: rubygem-actionview - Rendering framework putting the V in MVC (part of Rails) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Josef Stribny <jstribny> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, package-review, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-02 11:09:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Josef Stribny
2014-04-11 09:26:39 UTC
I'll take it for a review. * Test suite
- I would suggest to expand the test suite in %check section (see activemodel
for example).
- If you don't like the %check section, then you should move it into the %prep
section, though there are no directories prepared yet, so it would be weird.
%build section is definitely wrong place.
* %{bootstrap} macro
- Be sure to don't forget to re-enable the bootstrap macro.
- Actually, I am not sure why you suggest updated activesupport, but you are
not mentioning actionpack and activerecord, which are listed as BR of this
package. It doesn't look I can test the package without them.
I moved the test suite unpacking into %prep and I made necessary changes that will be required to run all the tests when the build dependencies are updated. Spec URL: http://data-strzibny.rhcloud.com/rubygem-actionview.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.src.rpm I made some adjustments to the spec file: Spec URL: http://data-strzibny.rhcloud.com/rubygem-actionview.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.src.rpm Dependencies to test: http://data-strzibny.rhcloud.com/rubygem-tzinfo-1.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-arel-5.0.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activesupport-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activemodel-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activerecord-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-rubygem-actionpack-4.1.0-1.fc21.noarch.rpm I hope I didn't miss any :). * Test suite
- You should run the test suite from "pushd .%{gem_instdir}". That way you
don't need to delete the test suite, i.e. you can remove the 'rm -rf test/'.
- Please remove the '&&' at the end of the first batch of tests. It makes the
testsuite to pass even if it fails.
* Useless provide
- You package has "Provides: rubygem(%{gem_name})" but it is now
autogenerated. Please remove the provide (it will avoid also one rpmlint
complaint).
* rpmlint
- rubygem-actionview-doc.noarch: W: summary-ended-with-dot C Documentation for
rubygem-actionview.
Otherwise the package looks good => APPROVED. Please fix the above mentioned minor nits prior importing and don't forget to disable bootstrap after first successful build.
Thanks, I will. New Package SCM Request ======================= Package Name: rubygem-actionview Short Description: Rendering framework putting the V in MVC (part of Rails) Owners: jstribny Branches: InitialCC: Git done (by process-git-requests). Built with f21-ruby target in rawhide for now. |