Spec URL: http://data-strzibny.rhcloud.com/rubygem-actionview.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-1.fc21.src.rpm Description: Simple, battle-tested conventions and helpers for building web pages. Fedora Account System Username: jstribny * Note: It already leverages the new packaging guidelines[1] and since it will be part of rails 4.1 update[2], you need updated rubygem-tzinfo and rubygem-activesupport packages. I built those updates locally [3,4] for testing this package. To run the test suite we would need other rails dependencies that depends on this package in runtime. This can be enabled after those components get updated during rails 4.1 change. [1] https://fedorahosted.org/fpc/ticket/409 [2] https://fedoraproject.org/wiki/Changes/Ruby_on_Rails_4.1 [3] http://data-strzibny.rhcloud.com/rubygem-tzinfo-1.1.0-1.fc21.noarch.rpm [4] http://data-strzibny.rhcloud.com/rubygem-activesupport-4.1.0-1.fc21.noarch.rpm
I'll take it for a review.
* Test suite - I would suggest to expand the test suite in %check section (see activemodel for example). - If you don't like the %check section, then you should move it into the %prep section, though there are no directories prepared yet, so it would be weird. %build section is definitely wrong place. * %{bootstrap} macro - Be sure to don't forget to re-enable the bootstrap macro. - Actually, I am not sure why you suggest updated activesupport, but you are not mentioning actionpack and activerecord, which are listed as BR of this package. It doesn't look I can test the package without them.
I moved the test suite unpacking into %prep and I made necessary changes that will be required to run all the tests when the build dependencies are updated. Spec URL: http://data-strzibny.rhcloud.com/rubygem-actionview.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.src.rpm
I made some adjustments to the spec file: Spec URL: http://data-strzibny.rhcloud.com/rubygem-actionview.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.src.rpm Dependencies to test: http://data-strzibny.rhcloud.com/rubygem-tzinfo-1.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-arel-5.0.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activesupport-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activemodel-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-activerecord-4.1.0-1.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-actionview-4.1.0-2.fc21.noarch.rpm http://data-strzibny.rhcloud.com/rubygem-rubygem-actionpack-4.1.0-1.fc21.noarch.rpm I hope I didn't miss any :).
* Test suite - You should run the test suite from "pushd .%{gem_instdir}". That way you don't need to delete the test suite, i.e. you can remove the 'rm -rf test/'. - Please remove the '&&' at the end of the first batch of tests. It makes the testsuite to pass even if it fails. * Useless provide - You package has "Provides: rubygem(%{gem_name})" but it is now autogenerated. Please remove the provide (it will avoid also one rpmlint complaint). * rpmlint - rubygem-actionview-doc.noarch: W: summary-ended-with-dot C Documentation for rubygem-actionview. Otherwise the package looks good => APPROVED. Please fix the above mentioned minor nits prior importing and don't forget to disable bootstrap after first successful build.
Thanks, I will. New Package SCM Request ======================= Package Name: rubygem-actionview Short Description: Rendering framework putting the V in MVC (part of Rails) Owners: jstribny Branches: InitialCC:
Git done (by process-git-requests).
Built with f21-ruby target in rawhide for now.