Bug 1087687

Summary:	If there is a problem with the database, don't add it to the mail_staging table
Product:	[Community] Bugzilla	Reporter:	Simon Green <sgreen>
Component:	Email Notifications	Assignee:	Simon Green <sgreen>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Simon Green <sgreen>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	4.4	CC:	ebaak, jmcdonal, rjoost
Target Milestone:	4.4
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.4.4019	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-07 00:58:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	956199
Bug Blocks:

Description Simon Green 2014-04-15 04:22:46 UTC

From the recursion-is-not-a-good-thing™ department:

When in a transaction, we add e-mails to the mailing_stating database so they can be sent once the transaction is committed. This creates an infinte loop if there is a problem with the database.

The solution is to add an extra parameter to the MessageToMTA sub to always send an e-mail and not use the queue.

Comment 1 Simon Green 2014-04-15 05:05:30 UTC

Checked all places that MessageToMTA was called, and also updated the upstream patch (b_g 448574)

Comment 2 Simon Green 2014-04-16 05:25:36 UTC

This was original released in 4.4.2018-2 but since it never was released publicly, will be part of 4.4.2019.

  -- simon

Comment 3 Simon Green 2014-05-07 00:58:30 UTC

This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.

  -- simon