Bug 1087687 - If there is a problem with the database, don't add it to the mail_staging table
Summary: If there is a problem with the database, don't add it to the mail_staging table
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: Email Notifications
Version: 4.4
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: 4.4
Assignee: Simon Green
QA Contact: Simon Green
URL:
Whiteboard:
Depends On: 956199
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-15 04:22 UTC by Simon Green
Modified: 2025-10-16 23:38 UTC (History)
3 users (show)

Fixed In Version: 4.4.4019
Clone Of:
Environment:
Last Closed: 2014-05-07 00:58:30 UTC
Embargoed:

Attachments (Terms of Use)

Description Simon Green 2014-04-15 04:22:46 UTC 
From the recursion-is-not-a-good-thing™ department:

When in a transaction, we add e-mails to the mailing_stating database so they can be sent once the transaction is committed. This creates an infinte loop if there is a problem with the database.

The solution is to add an extra parameter to the MessageToMTA sub to always send an e-mail and not use the queue.
Comment 1 Simon Green 2014-04-15 05:05:30 UTC 
Checked all places that MessageToMTA was called, and also updated the upstream patch (b_g 448574)
Comment 2 Simon Green 2014-04-16 05:25:36 UTC 
This was original released in 4.4.2018-2 but since it never was released publicly, will be part of 4.4.2019.

  -- simon
Comment 3 Simon Green 2014-05-07 00:58:30 UTC 
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.

  -- simon
Note You need to log in before you can comment on or make changes to this bug.