Bug 1088931
Summary: | Review Request: perl-MouseX-Types-Path-Class - A Path::Class type library for Mouse | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, ppisar |
Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-MouseX-Types-Path-Class-0.07-2.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-04-28 04:52:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1088856 | ||
Bug Blocks: | 1088946 |
Description
Paul Howarth
2014-04-17 13:01:13 UTC
URL and Source0 are usable. Ok. Source archive is original (SHA-256: 228d4b4f3f0ed9547278691d0b7c5fe53d90874a69df709a49703c6af87c09de). Ok. Summary verified from lib/MouseX/Types/Path/Class.pm. Ok. Description verified from lib/MouseX/Types/Path/Class.pm. Ok. License verified from lib/MouseX/Types/Path/Class.pm, README, README.mkdn. Ok. No XS code is compiled (inc/Module/Install/Can.pm:82:#include), noarch BuildArch is Ok. TODO: Constrain `perl(MouseX::Getopt)' optional dependency with `>= 0.22' (Makefile.PL:13). TODO: Move perl(Mouse) build-requirement into `Test Suite' section as you do not run-require it. TODO: Prune ./inc directory in the %prep section. You need to build-require: BuildRequires: perl(inc::Module::Install) BuildRequires: perl(Module::Install::AuthorTests) #BuildRequires: perl(Module::Install::AuthorRequires) BuildRequires: perl(Module::Install::ReadmeMarkdownFromPod) BuildRequires: perl(Module::Install::Repository) and do in %prep: rm -rf inc/* sed -i -e '/author_requires/d' Makefile.PL otherwise it will demand author test dependencies and you will have to install them and Module::Install::AuthorRequires. (That's because Module::Install boot-straps in author mode.) All tests pass. Ok. $ rpmlint perl-MouseX-Types-Path-Class.spec ../SRPMS/perl-MouseX-Types-Path-Class-0.07-1.fc21.src.rpm ../RPMS/noarch/perl-MouseX-Types-Path-Class-0.07-1.fc21.noarch.rpm perl-MouseX-Types-Path-Class.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-MouseX-Types-Path-Class.src: W: spelling-error %description -l en_US Coercions -> Coercion, Coercion's, Coercion s perl-MouseX-Types-Path-Class.src: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-MouseX-Types-Path-Class.src: W: spelling-error %description -l en_US TypeConstraints -> Type Constraints, Type-constraints, Constraints perl-MouseX-Types-Path-Class.src: W: spelling-error %description -l en_US Getopt -> Get opt, Get-opt, Treetop perl-MouseX-Types-Path-Class.noarch: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-MouseX-Types-Path-Class.noarch: W: spelling-error %description -l en_US Coercions -> Coercion, Coercion's, Coercion s perl-MouseX-Types-Path-Class.noarch: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-MouseX-Types-Path-Class.noarch: W: spelling-error %description -l en_US TypeConstraints -> Type Constraints, Type-constraints, Constraints perl-MouseX-Types-Path-Class.noarch: W: spelling-error %description -l en_US Getopt -> Get opt, Get-opt, Treetop 2 packages and 1 specfiles checked; 0 errors, 10 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MouseX-Types-Path-Class-0.07-1.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Apr 18 10:11 /usr/share/doc/perl-MouseX-Types-Path-Class -rw-r--r-- 1 root root 691 Apr 1 2012 /usr/share/doc/perl-MouseX-Types-Path-Class/Changes -rw-r--r-- 1 root root 1890 Apr 1 2012 /usr/share/doc/perl-MouseX-Types-Path-Class/README -rw-r--r-- 1 root root 2479 Apr 18 10:11 /usr/share/man/man3/MouseX::Types::Path::Class.3pm.gz drwxr-xr-x 2 root root 0 Apr 18 10:11 /usr/share/perl5/vendor_perl/MouseX drwxr-xr-x 2 root root 0 Apr 18 10:11 /usr/share/perl5/vendor_perl/MouseX/Types drwxr-xr-x 2 root root 0 Apr 18 10:11 /usr/share/perl5/vendor_perl/MouseX/Types/Path -rw-r--r-- 1 root root 2817 Apr 1 2012 /usr/share/perl5/vendor_perl/MouseX/Types/Path/Class.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MouseX-Types-Path-Class-0.07-1.fc21.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008_001 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(MouseX::Getopt) 1 perl(MouseX::Types) 1 perl(MouseX::Types::Mouse) 1 perl(Path::Class) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Constrain run-time dependency `perl(MouseX::Types)' with `>= 0.02'. $ rpm -q --provides -p ../RPMS/noarch/perl-MouseX-Types-Path-Class-0.07-1.fc21.noarch.rpm | sort | uniq -c 1 perl(MouseX::Types::Path::Class) = 0.07 1 perl-MouseX-Types-Path-Class = 0.07-1.fc21 Binary provides are Ok. $ resolvedeps f21-build ../RPMS/noarch/perl-MouseX-Types-Path-Class-0.07-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6752675). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building the package. Resolution: Package APPROVED. New Package SCM Request ======================= Package Name: perl-MouseX-Types-Path-Class Short Description: A Path::Class type library for Mouse Owners: pghmcfc Branches: f19 f20 epel7 InitialCC: perl-sig Thanks for the review Petr. I'll clean up the package prior to import. Git done (by process-git-requests). perl-MouseX-Types-Path-Class-0.07-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-MouseX-Types-Path-Class-0.07-2.fc19 perl-MouseX-Types-Path-Class-0.07-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-MouseX-Types-Path-Class-0.07-2.fc20 perl-MouseX-Types-Path-Class-0.07-2.fc19 has been pushed to the Fedora 19 testing repository. perl-MouseX-Types-Path-Class-0.07-2.fc19 has been pushed to the Fedora 19 stable repository. perl-MouseX-Types-Path-Class-0.07-2.fc20 has been pushed to the Fedora 20 stable repository. |