Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MouseX-ConfigFromFile/branches/fedora/perl-MouseX-ConfigFromFile.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-MouseX-ConfigFromFile/perl-MouseX-ConfigFromFile-0.05-1.fc21.src.rpm Description: This is an abstract role that provides an alternate constructor for creating objects using parameters passed in from a configuration file. The actual implementation of reading the configuration file is left to concrete subroles. It declares an attribute configfile and a class method new_with_config, and requires that concrete roles derived from it implement the class method get_config_from_file. Attributes specified directly as arguments to new_with_config supercede those in the configfile. Fedora Account System Username: pghmcfc
Unbundled Module::Install stuff in -2 Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MouseX-ConfigFromFile/branches/fedora/perl-MouseX-ConfigFromFile.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-MouseX-ConfigFromFile/perl-MouseX-ConfigFromFile-0.05-2.fc21.src.rpm
Though I personally am not a friend of the inc/ removal and see several other details within this spec, which do not fit my personal preferences, this package is OK. 2 remarks: * I'd recommend to at least add a comment to the spec explaining why you are removing inc/. * One minor oversight: %install rm -rf %{buildroot} As you do not support older RHELs in this spec, this rm should be removed. Anyway, APPROVED
New Package SCM Request ======================= Package Name: perl-MouseX-ConfigFromFile Short Description: An abstract Mouse role for setting attributes from a configfile Owners: pghmcfc Branches: f19 f20 epel7 InitialCC: perl-sig Thanks for the review Ralf. I'll update the spec prior to import.
Git done (by process-git-requests).
perl-MouseX-ConfigFromFile-0.05-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-MouseX-ConfigFromFile-0.05-3.fc19
perl-MouseX-ConfigFromFile-0.05-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-MouseX-ConfigFromFile-0.05-3.fc20
perl-MouseX-ConfigFromFile-0.05-3.fc19 has been pushed to the Fedora 19 testing repository.
perl-MouseX-ConfigFromFile-0.05-3.fc20 has been pushed to the Fedora 20 stable repository.
perl-MouseX-ConfigFromFile-0.05-3.fc19 has been pushed to the Fedora 19 stable repository.