Bug 1088946

Summary:	Review Request: perl-MouseX-ConfigFromFile - An abstract Mouse role for setting attributes from a configfile
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Ralf Corsepius <rc040203>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rc040203
Target Milestone:	---	Flags:	rc040203: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-MouseX-ConfigFromFile-0.05-3.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-02 20:58:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1088931
Bug Blocks:	1088950

Description Paul Howarth 2014-04-17 13:26:02 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MouseX-ConfigFromFile/branches/fedora/perl-MouseX-ConfigFromFile.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-MouseX-ConfigFromFile/perl-MouseX-ConfigFromFile-0.05-1.fc21.src.rpm

Description:
This is an abstract role that provides an alternate constructor for creating
objects using parameters passed in from a configuration file. The actual
implementation of reading the configuration file is left to concrete subroles.

It declares an attribute configfile and a class method new_with_config, and
requires that concrete roles derived from it implement the class method
get_config_from_file.

Attributes specified directly as arguments to new_with_config supercede those
in the configfile.

Fedora Account System Username: pghmcfc

Comment 1 Paul Howarth 2014-04-21 10:32:40 UTC

Unbundled Module::Install stuff in -2

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MouseX-ConfigFromFile/branches/fedora/perl-MouseX-ConfigFromFile.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-MouseX-ConfigFromFile/perl-MouseX-ConfigFromFile-0.05-2.fc21.src.rpm

Comment 2 Ralf Corsepius 2014-04-23 08:15:37 UTC

Though I personally am not a friend of the inc/ removal and see several other details within this spec, which do not fit my personal preferences, this package is OK. 

2 remarks:

* I'd recommend to at least add a comment to the spec explaining why you are removing inc/.

* One minor oversight:

%install
rm -rf %{buildroot}

As you do not support older RHELs in this spec, this rm should be removed.


Anyway, APPROVED

Comment 3 Paul Howarth 2014-04-23 08:48:10 UTC

New Package SCM Request
=======================
Package Name: perl-MouseX-ConfigFromFile
Short Description: An abstract Mouse role for setting attributes from a configfile
Owners: pghmcfc
Branches: f19 f20 epel7
InitialCC: perl-sig

Thanks for the review Ralf.

I'll update the spec prior to import.

Comment 4 Gwyn Ciesla 2014-04-24 12:51:11 UTC

Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-04-24 14:20:18 UTC

perl-MouseX-ConfigFromFile-0.05-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MouseX-ConfigFromFile-0.05-3.fc19

Comment 6 Fedora Update System 2014-04-24 14:20:26 UTC

perl-MouseX-ConfigFromFile-0.05-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-MouseX-ConfigFromFile-0.05-3.fc20

Comment 7 Fedora Update System 2014-04-25 04:28:31 UTC

perl-MouseX-ConfigFromFile-0.05-3.fc19 has been pushed to the Fedora 19 testing repository.

Comment 8 Fedora Update System 2014-05-02 20:58:29 UTC

perl-MouseX-ConfigFromFile-0.05-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 9 Fedora Update System 2014-05-02 21:06:38 UTC

perl-MouseX-ConfigFromFile-0.05-3.fc19 has been pushed to the Fedora 19 stable repository.