Bug 1089534

Summary:	'mount.glusterfs' does not handle names with '--' in them properly.
Product:	[Community] GlusterFS	Reporter:	Jeff Byers <jbyers>
Component:	scripts	Assignee:	Ric Wheeler <rwheeler>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.4.3	CC:	fharshav, gluster-bugs, jbyers, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-11 19:27:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Byers 2014-04-20 12:57:33 UTC

'mount.glusterfs' does not handle names with '--' in them properly.

The option procession of 'mount.glusterfs' does not handle names
with '--' properly, e.g. my--volname, and emits an "unrecognized option".

The work-around is to avoid such names, or to use the 'glusterfs' command
directly.

# gluster "volume" "create" "nas-volume--181-2" "transport" "tcp" "192.168.5.181:/exports/nas-segment-181-2/nas-volume--181-2"
volume create: nas-volume--181-2: success: please start the volume to access data
# gluster "volume" "start" "nas-volume--181-2"
volume start: nas-volume--181-2: success
# gluster volume info nas-volume--181-2

Volume Name: nas-volume--181-2
Type: Distribute
Volume ID: e292d86c-edf7-42af-a878-bdf7e5e07b4e
Status: Started
Number of Bricks: 1
Transport-type: tcp
Bricks:
Brick1: 192.168.5.181:/exports/nas-segment-181-2/nas-volume--181-2

# mkdir -p -m a=rwx /mnt/nas-volume--181-2
# mount -t glusterfs -o acl /var/lib/glusterd/vols/nas-volume--181-2/nas-volume--181-2-fuse.vol /mnt/nas-volume--181-2
/usr/local/sbin/glusterfs: unrecognized option '--181-2'

# mount.glusterfs -o acl /var/lib/glusterd/vols/nas-volume--181-2/nas-volume--181-2-fuse.vol /mnt/nas-volume--181-2
/usr/local/sbin/glusterfs: unrecognized option '--181-2'

# glusterfs --acl --volfile=/var/lib/glusterd/vols/nas-volume--181-2/nas-volume--181-2-fuse.vol /mnt/nas-volume--181-2
# mountpoint /mnt/nas-volume--181-2/
/mnt/nas-volume--181-2/ is a mountpoint

Comment 1 Harshavardhana 2014-06-10 06:37:58 UTC

Fixed in upstream after the changes pushed in, this won't be fixed in release-3.4 or release-3.5 - its been a disruptive change

commit 0404be9ca1d9fa15c83bc4132561091c1c839d84
Author: Harshavardhana <harsha>
Date:   Sat Sep 14 19:51:13 2013 -0700

    mount.glusterfs: getopts support and cleanup
    
    This patch is an attempt to provide some much needed
    cleanup for future maintenance of `mount.glusterfs`
    
    - Add checks for command failures
    - Spliting large code into subsequent simpler functions
    - Standardized variables
    - use 'bash' instead of 'sh' - since string manipulation
      and variable handling is far superior
    - Overall code cleanup and Copyright change to Red, Hat Inc.
    - Add new style of mounting with a comma separated list
      ~~~
      $ mount -t glusterfs <IP1/HOSTNAME1>,<IP2/HOSTNAME2>,..<IPN/HOSTNAMEN>:/<VOLUME> <MNT>
      ~~~
    - Update age old `manpage` with new options :-)
    
    Change-Id: I294e4d078a067d67d9a67eb8dde5eb2634cc0e45
    BUG: 1040348
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/5931
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 2 Niels de Vos 2014-07-11 19:27:30 UTC


*** This bug has been marked as a duplicate of bug 1040348 ***