Bug 1040348 - mount.glusterfs needs cleanup and requires option validation using getopt
Summary: mount.glusterfs needs cleanup and requires option validation using getopt
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: fuse
Version: mainline
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Harshavardhana
QA Contact:
URL:
Whiteboard:
: 1089534 (view as bug list)
Depends On:
Blocks: 928781
TreeView+ depends on / blocked
 
Reported: 2013-12-11 09:20 UTC by Harshavardhana
Modified: 2015-03-23 01:04 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:25:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Harshavardhana 2013-12-11 09:20:00 UTC
Present mount.glusterfs is un-maintainable, ensure cleanup and also standardize option validation using bash "getopt"

Other features includes support for multiple styles of volume fetch specification

Example:

mount -t glusterfs IP1,IP2,...IPN:/<VOLUME> <MOUNT-POINT>

mount -t glusterfs -obackupvolfile-server=IP2 IP1:/<VOLUME> <MOUNT-POINT>

mount -t glusterfs -obackup-volfile-servers=IP2,IP3,..IPN  IP1:/<VOLUME> <MOUNT-POINT>

Comment 1 Anand Avati 2013-12-11 09:20:41 UTC
REVIEW: http://review.gluster.org/5931 (mount.glusterfs: getopts support and cleanup) posted (#14) for review on master by Harshavardhana (harsha)

Comment 2 Anand Avati 2013-12-11 09:23:38 UTC
REVIEW: http://review.gluster.org/5931 (mount.glusterfs: getopts support and cleanup) posted (#15) for review on master by Harshavardhana (harsha)

Comment 3 Anand Avati 2013-12-13 10:26:01 UTC
COMMIT: http://review.gluster.org/5931 committed in master by Vijay Bellur (vbellur) 
------
commit 0404be9ca1d9fa15c83bc4132561091c1c839d84
Author: Harshavardhana <harsha>
Date:   Sat Sep 14 19:51:13 2013 -0700

    mount.glusterfs: getopts support and cleanup
    
    This patch is an attempt to provide some much needed
    cleanup for future maintenance of `mount.glusterfs`
    
    - Add checks for command failures
    - Spliting large code into subsequent simpler functions
    - Standardized variables
    - use 'bash' instead of 'sh' - since string manipulation
      and variable handling is far superior
    - Overall code cleanup and Copyright change to Red, Hat Inc.
    - Add new style of mounting with a comma separated list
      ~~~
      $ mount -t glusterfs <IP1/HOSTNAME1>,<IP2/HOSTNAME2>,..<IPN/HOSTNAMEN>:/<VOLUME> <MNT>
      ~~~
    - Update age old `manpage` with new options :-)
    
    Change-Id: I294e4d078a067d67d9a67eb8dde5eb2634cc0e45
    BUG: 1040348
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/5931
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2013-12-20 07:13:38 UTC
REVIEW: http://review.gluster.org/6545 (mount.glusterfs:export PATH environment variable) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 5 Anand Avati 2013-12-24 10:32:37 UTC
COMMIT: http://review.gluster.org/6545 committed in master by Vijay Bellur (vbellur) 
------
commit 67ddf10d07ea14e1b9faeabde9dfc700247a6377
Author: Ravishankar N <ravishankar>
Date:   Fri Dec 20 12:27:30 2013 +0530

    mount.glusterfs:export PATH environment variable
    
    Problem: spurious warning:
    mount -t glusterfs 10.70.7.228:repvol /mnt/fuse_mnt/
    WARNING: getfattr not found, certain checks will be skipped..
    
    Fix:
    export PATH so that getfattr search succeeds.
    
    Change-Id: Ib19e2899e43a7d763a136b9fbc90823f743597a5
    BUG: 1040348
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/6545
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Harshavardhana <harsha>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Niels de Vos 2014-07-11 19:27:30 UTC
*** Bug 1089534 has been marked as a duplicate of this bug. ***

Comment 7 Niels de Vos 2014-09-22 12:33:31 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 8 Niels de Vos 2014-11-11 08:25:28 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.