Bug 1089949
| Summary: | Review Request: perl-Sort-Maker - Simple way to make efficient sort subs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rc040203 |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Sort-Maker-0.06-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-08 21:59:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Bachelot
2014-04-22 09:34:08 UTC
Similarly as with perl-DB_File-Lock:
* MUSTFIX: Missing BRs:
+BuildRequires: perl(base)
+BuildRequires: perl(Benchmark)
+BuildRequires: perl(Data::Dumper)
+BuildRequires: perl(Exporter)
BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(lib)
+BuildRequires: perl(List::Util)
+BuildRequires: perl(strict)
BuildRequires: perl(Test::More)
+BuildRequires: perl(vars)
+BuildRequires: perl(warnings)
I am not 100% sure about List::Utils, but believe it should both be BR'd and Required:'ed
(IIUC, Sort-Maker-0.06/Sort/Maker.pm generates inlined code, which depends upon List::Util)
* CONSIDER removing
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
(It's not needed in Fedora, anymore).
Thanks Ralf. Updated as you suggested. Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Sort-Maker.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Sort-Maker-0.06-2.fc20.src.rpm APPROVED New Package SCM Request ======================= Package Name: perl-Sort-Maker Short Description: Simple way to make efficient sort subs Owners: xavierb Branches: f20 el6 epel7 InitialCC: perl-sig Thanks for the review Ralf. Git done (by process-git-requests). perl-Sort-Maker-0.06-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Sort-Maker-0.06-2.el6 perl-Sort-Maker-0.06-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Sort-Maker-0.06-2.fc20 perl-Sort-Maker-0.06-2.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Sort-Maker-0.06-2.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Sort-Maker-0.06-2.fc20 has been pushed to the Fedora 20 stable repository. |