Bug 1089949 - Review Request: perl-Sort-Maker - Simple way to make efficient sort subs
Summary: Review Request: perl-Sort-Maker - Simple way to make efficient sort subs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-22 09:34 UTC by Xavier Bachelot
Modified: 2014-05-09 03:03 UTC (History)
2 users (show)

Fixed In Version: perl-Sort-Maker-0.06-2.fc20
Clone Of:
Environment:
Last Closed: 2014-05-08 21:59:06 UTC
Type: ---
Embargoed:
rc040203: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2014-04-22 09:34:08 UTC
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Sort-Maker.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Sort-Maker-0.06-1.fc20.src.rpm
Description: Simple way to make efficient sort subs
Fedora Account System Username: xavierb

Comment 1 Ralf Corsepius 2014-04-22 10:16:31 UTC
Similarly as with perl-DB_File-Lock:

* MUSTFIX: Missing BRs:

+BuildRequires:  perl(base)
+BuildRequires:  perl(Benchmark)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(List::Util)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
+BuildRequires:  perl(vars)
+BuildRequires:  perl(warnings)

I am not 100% sure about List::Utils, but believe it should both be BR'd and Required:'ed

(IIUC, Sort-Maker-0.06/Sort/Maker.pm generates inlined code, which depends upon List::Util)

* CONSIDER removing
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
(It's not needed in Fedora, anymore).

Comment 2 Xavier Bachelot 2014-04-22 11:29:38 UTC
Thanks Ralf. Updated as you suggested.

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Sort-Maker.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Sort-Maker-0.06-2.fc20.src.rpm

Comment 3 Ralf Corsepius 2014-04-22 12:04:03 UTC
APPROVED

Comment 4 Xavier Bachelot 2014-04-22 14:42:58 UTC
New Package SCM Request
=======================
Package Name: perl-Sort-Maker
Short Description: Simple way to make efficient sort subs
Owners: xavierb
Branches: f20 el6 epel7
InitialCC: perl-sig


Thanks for the review Ralf.

Comment 5 Gwyn Ciesla 2014-04-22 15:49:23 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-04-23 08:50:53 UTC
perl-Sort-Maker-0.06-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Sort-Maker-0.06-2.el6

Comment 7 Fedora Update System 2014-04-23 08:51:01 UTC
perl-Sort-Maker-0.06-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Sort-Maker-0.06-2.fc20

Comment 8 Fedora Update System 2014-04-23 21:42:09 UTC
perl-Sort-Maker-0.06-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 9 Fedora Update System 2014-05-08 21:59:06 UTC
perl-Sort-Maker-0.06-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 10 Fedora Update System 2014-05-09 03:03:06 UTC
perl-Sort-Maker-0.06-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.