Bug 1091375
| Summary: | Review Request: tmate - Instant terminal sharing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Schneider <asn> |
| Component: | Package Review | Assignee: | Jakub Hrozek <jhrozek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | asn, i, package-review |
| Target Milestone: | --- | Flags: | jhrozek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | tmate-1.8.9-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-08 10:02:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andreas Schneider
2014-04-25 12:49:40 UTC
I reviewed the package on IRC and requested some changes:
* Source0 must point to the upstream tarball
* %makeinstall should not be used
* %make %{?_smp_mflags} should be used instead of -j%jobs magic
* BuildRequires gcc-c++ is not needed
Spec URL: http://xor.cryptomilk.org/rpm/tmate/tmate.spec SRPM URL: http://xor.cryptomilk.org/rpm/tmate/tmate-1.8.9-2.src.rpm I've fixed all the points above. rpmlint output:
Rpmlint
-------
Checking: tmate-1.8.9-2.x86_64.rpm
tmate-1.8.9-2.src.rpm
tmate.x86_64: W: spelling-error %description -l en_US tmux -> tux
tmate.x86_64: E: call-to-mktemp /usr/bin/tmate
tmate.src: W: spelling-error %description -l en_US tmux -> tux
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint tmate
tmate.x86_64: W: spelling-error %description -l en_US tmux -> tux
tmate.x86_64: E: call-to-mktemp /usr/bin/tmate
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
# echo 'rpmlint-done:'
The call to mktemp should be solved at the upstream level, not in the package. The typo is not a typo, just a spurious rpmlint warning.
Koji build looks good: http://koji.fedoraproject.org/koji/taskinfo?taskID=6793929 The specfile looks good to me now, too. APPROVED. New Package SCM Request ======================= Package Name: tmate Short Description: Instant terminal sharing Owners: asn Branches: f20 InitialCC: jhrozek Git done (by process-git-requests). 1. Release: 2 Why did you think it's OK? 2. Source0: https://github.com/nviennot/tmate/archive/1.8.9.tar.gz Why not use %{version} macro(trivial)? 3. Why still have %defattr(-,root,root)? tmate-1.8.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/tmate-1.8.9-3.fc20 tmate-1.8.9-3.fc20 has been pushed to the Fedora 20 testing repository. tmate-1.8.9-3.fc20 has been pushed to the Fedora 20 stable repository. |