Spec URL: http://xor.cryptomilk.org/rpm/tmate/tmate.spec SRPM URL: http://xor.cryptomilk.org/rpm/tmate/tmate-1.8.9-1.src.rpm Description: Tmate is a fork of tmux providing an instant pairing solution. Fedora Account System Username: asn
I reviewed the package on IRC and requested some changes: * Source0 must point to the upstream tarball * %makeinstall should not be used * %make %{?_smp_mflags} should be used instead of -j%jobs magic * BuildRequires gcc-c++ is not needed
Spec URL: http://xor.cryptomilk.org/rpm/tmate/tmate.spec SRPM URL: http://xor.cryptomilk.org/rpm/tmate/tmate-1.8.9-2.src.rpm I've fixed all the points above.
rpmlint output: Rpmlint ------- Checking: tmate-1.8.9-2.x86_64.rpm tmate-1.8.9-2.src.rpm tmate.x86_64: W: spelling-error %description -l en_US tmux -> tux tmate.x86_64: E: call-to-mktemp /usr/bin/tmate tmate.src: W: spelling-error %description -l en_US tmux -> tux 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint tmate tmate.x86_64: W: spelling-error %description -l en_US tmux -> tux tmate.x86_64: E: call-to-mktemp /usr/bin/tmate 1 packages and 0 specfiles checked; 1 errors, 1 warnings. # echo 'rpmlint-done:' The call to mktemp should be solved at the upstream level, not in the package. The typo is not a typo, just a spurious rpmlint warning.
Koji build looks good: http://koji.fedoraproject.org/koji/taskinfo?taskID=6793929 The specfile looks good to me now, too. APPROVED.
New Package SCM Request ======================= Package Name: tmate Short Description: Instant terminal sharing Owners: asn Branches: f20 InitialCC: jhrozek
Git done (by process-git-requests).
1. Release: 2 Why did you think it's OK? 2. Source0: https://github.com/nviennot/tmate/archive/1.8.9.tar.gz Why not use %{version} macro(trivial)? 3. Why still have %defattr(-,root,root)?
tmate-1.8.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/tmate-1.8.9-3.fc20
tmate-1.8.9-3.fc20 has been pushed to the Fedora 20 testing repository.
tmate-1.8.9-3.fc20 has been pushed to the Fedora 20 stable repository.