Bug 1092397

Summary: [RFE] Warn when answer file does not exist
Product: [oVirt] otopi Reporter: Petr Beňas <pbenas>
Component: Plugins.coreAssignee: Alon Bar-Lev <alonbl>
Status: CLOSED CURRENTRELEASE QA Contact: Pavel Stehlik <pstehlik>
Severity: low Docs Contact:
Priority: unspecified    
Version: ---CC: aberezin, acathrow, bazulay, dfediuck, didi, dougsland, gklein, iheim, lveyde, pstehlik, Rhev-m-bugs, rhodain, sbonazzo, sherold, stirabos, yeylon
Target Milestone: ---Keywords: Improvement
Target Release: 1.3.0Flags: dfediuck: devel_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-12 18:50:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1142923, 1156165    

Description Petr Beňas 2014-04-29 08:50:38 UTC
Description of problem:
[root@pb-rh34 ~]# ls nonexistent
ls: cannot access nonexistent: No such file or directory
[root@pb-rh34 ~]# rhevm-setup --config-append=nonexistent
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging.conf', '/etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf']
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20140429104643.log
          Version: otopi-1.2.0 (otopi-1.2.0-1.el6ev)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
<snip/>

Version-Release number of selected component (if applicable):
rhevm-setup-3.4.0-0.15.beta3.el6ev.noarch

Actual results:
Wrong filename is silently ignored

Expected results:
A wargning.

Comment 1 Sandro Bonazzola 2014-05-06 06:14:47 UTC
I think this  should be solved at otopi level in core.config plugin.
Files specified as additional configuration should show a warning to the user if not existing.

Comment 2 Alon Bar-Lev 2014-05-06 18:04:13 UTC
by design configuration is allowed to be missing.

the search for configuration is:

1. file: configuration name
2. directory: configuration name + '.d/*.conf'

missing configuration is valid.

I added a warning for missing config append, although not very happy... as I can think of many scenarios in which this is valid.

Comment 3 Alon Bar-Lev 2014-05-06 18:59:41 UTC
Not sure how do I set 3.4.1 without robot revert.

Comment 5 Sandro Bonazzola 2014-05-07 06:59:19 UTC
(In reply to Alon Bar-Lev from comment #3)
> Not sure how do I set 3.4.1 without robot revert.

You need 3.5.0 and 3.4.z flags request.

Comment 6 Alon Bar-Lev 2014-05-07 07:07:42 UTC
(In reply to Sandro Bonazzola from comment #5)
> (In reply to Alon Bar-Lev from comment #3)
> > Not sure how do I set 3.4.1 without robot revert.
> 
> You need 3.5.0 and 3.4.z flags request.

Probably I have no permissions as I did not see the 3.4.z.

Thank you for taking care of that.

Comment 7 Yedidyah Bar David 2016-08-17 07:35:18 UTC
*** Bug 1224720 has been marked as a duplicate of this bug. ***