Bug 1224720
| Summary: | hosted-engine does not fail when incorrect answer file is provided | ||
|---|---|---|---|
| Product: | [oVirt] otopi | Reporter: | Roman Hodain <rhodain> |
| Component: | Plugins.General | Assignee: | Yedidyah Bar David <didi> |
| Status: | CLOSED DUPLICATE | QA Contact: | Pavel Stehlik <pstehlik> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.5.1 | CC: | bugs, didi, lsurette, oourfali, rhodain, sbonazzo, ykaul, ylavi |
| Target Milestone: | ovirt-4.1.0-alpha | Flags: | sbonazzo:
ovirt-4.1?
sbonazzo: planning_ack? rhodain: devel_ack? sbonazzo: testing_ack? |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-17 07:35:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Currently there is just a warning if one of more configuration file is missing.
[root@foobar ovirt-hosted-engine-setup]# hosted-engine --deploy --config-append=wrong.conf
[ INFO ] Stage: Initializing
[ INFO ] Generating a temporary VNC password.
[ INFO ] Stage: Environment setup
During customization use CTRL-D to abort.
Continuing will configure this host for serving as hypervisor and create a VM where you have to install the engine afterwards.
Are you sure you want to continue? (Yes, No)[Yes]:
[ INFO ] Hardware supports virtualization
Configuration files: []
[WARNING] The following configuration files are missing: wrong.conf.
Log file: /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-20160805175535-fwn3pj.log
Version: otopi-1.5.1 (otopi-1.5.1-1.el7.centos)
This is part of otopi, moving there if we decide to change that behavior and explicitly fail.
(In reply to Simone Tiraboschi from comment #2) > Currently there is just a warning if one of more configuration file is > missing. > > [root@foobar ovirt-hosted-engine-setup]# hosted-engine --deploy > --config-append=wrong.conf > [ INFO ] Stage: Initializing > [ INFO ] Generating a temporary VNC password. > [ INFO ] Stage: Environment setup > During customization use CTRL-D to abort. > Continuing will configure this host for serving as hypervisor and > create a VM where you have to install the engine afterwards. > Are you sure you want to continue? (Yes, No)[Yes]: > [ INFO ] Hardware supports virtualization > Configuration files: [] > [WARNING] The following configuration files are missing: wrong.conf. This warning was added for bug 1092397. Close as duplicate? Error? Error and abort? Something else? (In reply to Yedidyah Bar David from comment #3) > (In reply to Simone Tiraboschi from comment #2) > > Currently there is just a warning if one of more configuration file is > > missing. > > > > [root@foobar ovirt-hosted-engine-setup]# hosted-engine --deploy > > --config-append=wrong.conf > > [ INFO ] Stage: Initializing > > [ INFO ] Generating a temporary VNC password. > > [ INFO ] Stage: Environment setup > > During customization use CTRL-D to abort. > > Continuing will configure this host for serving as hypervisor and > > create a VM where you have to install the engine afterwards. > > Are you sure you want to continue? (Yes, No)[Yes]: > > [ INFO ] Hardware supports virtualization > > Configuration files: [] > > [WARNING] The following configuration files are missing: wrong.conf. > > This warning was added for bug 1092397. Close as duplicate? Error? Error and > abort? Something else? Close as duplicate from my point of view. *** This bug has been marked as a duplicate of bug 1092397 *** |
Description of problem: hosted-engine accepts only a full path to the answer file. If only a file name is specified the data is not loaded and the setup continues silently with the default values. Version-Release number of selected component (if applicable): ovirt-hosted-engine-setup-1.2.2-3.el6ev.noarch How reproducible: 100% Steps to Reproduce: 1. Make sure that file test.conf does not exists 2. Run # hosted-engine --deploy --config-append=test.conf Actual results: Installation continues with the default values Expected results: Error message is displayed Additional info: This behaviour is confusing as the user doe not know why the parameters are not taken under consideration in case of typo or incorrect path.