Bug 1093640
| Summary: | Review Request: perl-Protocol-WebSocket - WebSocket protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Protocol-WebSocket-0.17-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-17 06:30:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Dick
2014-05-02 09:34:50 UTC
koji builds at el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6805821 rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6805837 FIX: You're missing perl(Exporter) as a buildtime dep for EPEL6, required by your patch. TIP: Instead of using dos2unix, a simple sed call would be sufficient. Oh, and patch2 could have a better name. This one doesn't say much. Fixed. koji builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=6817662 el6 rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6817636 You suddenly list perl(Config) twice, why? Also, perl(Symbol) is not required; it's only used by Test::Builder::Tester which is only required by the unused Test::Builder::Tester::Color. These are no blockers but please drop lines 19-21 and 38-40 before pushing. Done. Thanks for the review Petr. Sorry, i'm a bit tired atm. New Package SCM Request ======================= Package Name: perl-Protocol-WebSocket Short Description: WebSocket protocol Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Protocol-WebSocket-0.17-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Protocol-WebSocket-0.17-1.fc20 perl-Protocol-WebSocket-0.17-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Protocol-WebSocket-0.17-1.el6 perl-Protocol-WebSocket-0.17-1.fc20 has been pushed to the Fedora 20 testing repository. perl-Protocol-WebSocket-0.17-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Protocol-WebSocket-0.17-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |