Bug 1093640 - Review Request: perl-Protocol-WebSocket - WebSocket protocol
Summary: Review Request: perl-Protocol-WebSocket - WebSocket protocol
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-02 09:34 UTC by David Dick
Modified: 2014-05-24 18:02 UTC (History)
2 users (show)

Fixed In Version: perl-Protocol-WebSocket-0.17-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-17 06:30:25 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-05-02 09:34:50 UTC
Spec URL: http://ddick.fedorapeople.org/packages/perl-Protocol-WebSocket.spec
SRPM URL: http://ddick.fedorapeople.org/packages/perl-Protocol-WebSocket-0.17-1.fc20.src.rpm
Description: WebSocket protocol
Fedora Account System Username: ddick

Comment 2 Petr Šabata 2014-05-05 13:54:47 UTC
FIX: You're missing perl(Exporter) as a buildtime dep for EPEL6, required by your patch.
TIP: Instead of using dos2unix, a simple sed call would be sufficient.

Comment 3 Petr Šabata 2014-05-05 13:55:24 UTC
Oh, and patch2 could have a better name.  This one doesn't say much.

Comment 5 Petr Šabata 2014-05-06 11:27:00 UTC
You suddenly list perl(Config) twice, why?

Also, perl(Symbol) is not required; it's only used by Test::Builder::Tester which is only required by the unused Test::Builder::Tester::Color.

These are no blockers but please drop lines 19-21 and 38-40 before pushing.

Comment 6 David Dick 2014-05-06 11:31:59 UTC
Done.  Thanks for the review Petr.  Sorry, i'm a bit tired atm.

New Package SCM Request
=======================
Package Name: perl-Protocol-WebSocket
Short Description: WebSocket protocol
Owners: ddick
Branches: f20 el6 epel7
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2014-05-06 11:55:43 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-05-07 10:13:37 UTC
perl-Protocol-WebSocket-0.17-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Protocol-WebSocket-0.17-1.fc20

Comment 9 Fedora Update System 2014-05-07 10:53:58 UTC
perl-Protocol-WebSocket-0.17-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Protocol-WebSocket-0.17-1.el6

Comment 10 Fedora Update System 2014-05-08 09:59:56 UTC
perl-Protocol-WebSocket-0.17-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Fedora Update System 2014-05-17 06:30:25 UTC
perl-Protocol-WebSocket-0.17-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2014-05-24 18:02:36 UTC
perl-Protocol-WebSocket-0.17-1.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.